From 51f2dbd64df9f49a75beb5e6a4627d80303b1ed1 Mon Sep 17 00:00:00 2001 From: Manish Goregaokar Date: Sun, 29 Jun 2014 14:37:23 +0530 Subject: [PATCH] Fix wpt failure on responseType setter --- src/components/script/dom/xmlhttprequest.rs | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/components/script/dom/xmlhttprequest.rs b/src/components/script/dom/xmlhttprequest.rs index 8b0dc2184eb..86112f045b5 100644 --- a/src/components/script/dom/xmlhttprequest.rs +++ b/src/components/script/dom/xmlhttprequest.rs @@ -577,13 +577,11 @@ impl<'a> XMLHttpRequestMethods<'a> for JSRef<'a, XMLHttpRequest> { self.response_type.deref().get() } fn SetResponseType(&self, response_type: XMLHttpRequestResponseType) -> ErrorResult { - if self.sync.deref().get() { - // FIXME: When Workers are implemented, there should be - // an additional check that this is a document environment - return Err(InvalidState); - } + // FIXME: When Workers are implemented, there should be + // an additional check that this is a document environment match self.ready_state.deref().get() { Loading | XHRDone => Err(InvalidState), + _ if self.sync.deref().get() => Err(InvalidAccess), _ => { self.response_type.deref().set(response_type); Ok(())