Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-04 13:10:20 +01:00
Code Issues Projects Releases Packages Wiki Activity

GC hazard fix in customelementregistry.rs (#34019)

Browse source 
* GC hazard fix in customelement.registry.rs

Signed-off-by: L Ashwin B <lashwinib@gmail.com>

* removed redundant borrow

Signed-off-by: L Ashwin B <lashwinib@gmail.com>

---------

Signed-off-by: L Ashwin B <lashwinib@gmail.com>
This commit is contained in:
chickenleaf 2024-10-26 21:48:00 +05:30 • committed by GitHub
parent 82c9d41330
commit 53911f4e5a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 4 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

10
components/script/dom/customelementregistry.rs
View file

@ -598,13 +598,11 @@ impl CustomElementRegistryMethods for CustomElementRegistry {
} }
} }
// Step 3 // Steps 3, 4, 5
let mut map = self.when_defined.borrow_mut(); let existing_promise = self.when_defined.borrow().get(&name).cloned();
let promise = existing_promise.unwrap_or_else(|| {
// Steps 4, 5
let promise = map.get(&name).cloned().unwrap_or_else(|| {
let promise = Promise::new_in_current_realm(comp, can_gc); let promise = Promise::new_in_current_realm(comp, can_gc);
map.insert(name, promise.clone()); self.when_defined.borrow_mut().insert(name, promise.clone());
promise promise
}); });