From 53e8f7d823f6d89c9548768859b550d3d1d9d636 Mon Sep 17 00:00:00 2001 From: David Zbarsky Date: Sat, 15 Aug 2015 01:11:55 -0400 Subject: [PATCH] Get rid of some cloning --- components/style/values.rs | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/components/style/values.rs b/components/style/values.rs index 37fcc46d3a0..c768a010843 100644 --- a/components/style/values.rs +++ b/components/style/values.rs @@ -502,9 +502,8 @@ pub mod specified { } fn simplify_sum_to_number(node: &CalcSumNode) -> Option { - let node = node.clone(); let mut sum = 0.; - for product in node.products { + for product in &node.products { match Calc::simplify_product_to_number(product) { Some(number) => sum += number, _ => return None @@ -513,10 +512,10 @@ pub mod specified { Some(sum) } - fn simplify_product_to_number(node: CalcProductNode) -> Option { + fn simplify_product_to_number(node: &CalcProductNode) -> Option { let mut product = 1.; - for value in node.values { - match Calc::simplify_value_to_number(&value) { + for value in &node.values { + match Calc::simplify_value_to_number(value) { Some(number) => product *= number, _ => return None } @@ -526,8 +525,7 @@ pub mod specified { fn simplify_products_in_sum(node: &CalcSumNode) -> Result { let mut simplified = Vec::new(); - let node = node.clone(); - for product in node.products { + for product in &node.products { match try!(Calc::simplify_product(product)) { SimplifiedValueNode::Sum(box sum) => simplified.push_all(&sum.values), val => simplified.push(val),