Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-07 14:35:33 +01:00
Code Issues Projects Releases Packages Wiki Activity

Merge pull request #413 from ILyoan/remove_copy_hubbub

Browse source 
Remove unnecessary copying in hubbub parser
This commit is contained in:
Jack Moffitt 2013-05-02 20:22:35 -07:00
commit 53f8f15215
1 changed files with 6 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

18
src/servo/html/hubbub_html_parser.rs
View file

@ -260,20 +260,14 @@ pub fn parse_html(url: Url,
}, },
create_doctype: |doctype: ~hubbub::Doctype| { create_doctype: |doctype: ~hubbub::Doctype| {
debug!("create doctype"); debug!("create doctype");
// TODO: remove copying here by using struct pattern matching to let ~hubbub::Doctype {name: name,
// move all ~strs at once (blocked on Rust #3845, #3846, #3847) public_id: public_id,
let public_id = match &doctype.public_id { system_id: system_id,
&None => None, force_quirks: force_quirks } = doctype;
&Some(ref id) => Some(copy *id) let node = ~Doctype::new(name,
};
let system_id = match &doctype.system_id {
&None => None,
&Some(ref id) => Some(copy *id)
};
let node = ~Doctype::new(copy doctype.name,
public_id, public_id,
system_id, system_id,
doctype.force_quirks); force_quirks);
unsafe { unsafe {
Node::as_abstract_node(node).to_hubbub_node() Node::as_abstract_node(node).to_hubbub_node()
} }