refactor: add CanGc as argument to extract_size_algorithm (#35593)

Signed-off-by: Yerkebulan Tulibergenov <yerkebulan@gmail.com>
This commit is contained in:
Yerkebulan Tulibergenov 2025-02-21 18:25:59 -08:00 committed by GitHub
parent f7c1cd4635
commit 54286229ea
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 8 additions and 5 deletions

View file

@ -122,7 +122,10 @@ pub(crate) fn extract_high_water_mark(
/// If the size algorithm is not set, return a fallback function which always returns 1. /// If the size algorithm is not set, return a fallback function which always returns 1.
/// ///
/// <https://streams.spec.whatwg.org/#make-size-algorithm-from-size-function> /// <https://streams.spec.whatwg.org/#make-size-algorithm-from-size-function>
pub(crate) fn extract_size_algorithm(strategy: &QueuingStrategy) -> Rc<QueuingStrategySize> { pub(crate) fn extract_size_algorithm(
strategy: &QueuingStrategy,
_can_gc: CanGc,
) -> Rc<QueuingStrategySize> {
if strategy.size.is_none() { if strategy.size.is_none() {
let cx = GlobalScope::get_cx(); let cx = GlobalScope::get_cx();
let fun_obj = native_raw_obj_fn!(cx, count_queuing_strategy_size, c"size", 0, 0); let fun_obj = native_raw_obj_fn!(cx, count_queuing_strategy_size, c"size", 0, 0);

View file

@ -128,7 +128,7 @@ fn create_readable_stream(
// If sizeAlgorithm was not passed, set it to an algorithm that returns 1. // If sizeAlgorithm was not passed, set it to an algorithm that returns 1.
let size_algorithm = queuing_strategy let size_algorithm = queuing_strategy
.size .size
.unwrap_or(extract_size_algorithm(&QueuingStrategy::empty())); .unwrap_or(extract_size_algorithm(&QueuingStrategy::empty(), can_gc));
// Assert: ! IsNonNegativeNumber(highWaterMark) is true. // Assert: ! IsNonNegativeNumber(highWaterMark) is true.
assert!(high_water_mark >= 0.0); assert!(high_water_mark >= 0.0);
@ -274,7 +274,7 @@ impl ReadableStream {
global, global,
source, source,
1.0, 1.0,
extract_size_algorithm(&QueuingStrategy::empty()), extract_size_algorithm(&QueuingStrategy::empty(), can_gc),
can_gc, can_gc,
); );
controller.setup(stream.clone(), can_gc)?; controller.setup(stream.clone(), can_gc)?;
@ -931,7 +931,7 @@ impl ReadableStreamMethods<crate::DomTypeHolder> for ReadableStream {
let high_water_mark = extract_high_water_mark(strategy, 1.0)?; let high_water_mark = extract_high_water_mark(strategy, 1.0)?;
// Let sizeAlgorithm be ! ExtractSizeAlgorithm(strategy). // Let sizeAlgorithm be ! ExtractSizeAlgorithm(strategy).
let size_algorithm = extract_size_algorithm(strategy); let size_algorithm = extract_size_algorithm(strategy, can_gc);
let controller = ReadableStreamDefaultController::new( let controller = ReadableStreamDefaultController::new(
global, global,

View file

@ -877,7 +877,7 @@ impl WritableStreamMethods<crate::DomTypeHolder> for WritableStream {
let stream = WritableStream::new_with_proto(global, proto, can_gc); let stream = WritableStream::new_with_proto(global, proto, can_gc);
// Let sizeAlgorithm be ! ExtractSizeAlgorithm(strategy). // Let sizeAlgorithm be ! ExtractSizeAlgorithm(strategy).
let size_algorithm = extract_size_algorithm(strategy); let size_algorithm = extract_size_algorithm(strategy, can_gc);
// Let highWaterMark be ? ExtractHighWaterMark(strategy, 1). // Let highWaterMark be ? ExtractHighWaterMark(strategy, 1).
let high_water_mark = extract_high_water_mark(strategy, 1.0)?; let high_water_mark = extract_high_water_mark(strategy, 1.0)?;