mirror of
https://github.com/servo/servo.git
synced 2025-08-03 12:40:06 +01:00
Auto merge of #10903 - broesamle:issue10877-HTMLAnchorElement-setter-panic, r=jdm
Avoid panics when using HTMLAnchorElement attribute setters `expected: OK` still explicitly mentioned in .ini file. Shall I remove it? Fixes #10877. <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10903) <!-- Reviewable:end -->
This commit is contained in:
commit
545da3844a
3 changed files with 86 additions and 13 deletions
|
@ -35936,7 +35936,16 @@
|
|||
"local_changes": {
|
||||
"deleted": [],
|
||||
"deleted_reftests": {},
|
||||
"items": {},
|
||||
"items": {
|
||||
"testharness": {
|
||||
"html/semantics/links/links-created-by-a-and-area-elements/htmlanchorelement_attribute-getter-setter.html": [
|
||||
{
|
||||
"path": "html/semantics/links/links-created-by-a-and-area-elements/htmlanchorelement_attribute-getter-setter.html",
|
||||
"url": "/html/semantics/links/links-created-by-a-and-area-elements/htmlanchorelement_attribute-getter-setter.html"
|
||||
}
|
||||
]
|
||||
}
|
||||
},
|
||||
"reftest_nodes": {}
|
||||
},
|
||||
"reftest_nodes": {
|
||||
|
|
|
@ -0,0 +1,65 @@
|
|||
<!doctype html>
|
||||
<meta charset="utf-8">
|
||||
<html>
|
||||
<head>
|
||||
<title>HTMLAnchorElement getters and setters</title>
|
||||
<script src="/resources/testharness.js"></script>
|
||||
<script src="/resources/testharnessreport.js"></script>
|
||||
<a>anchor</a>
|
||||
<script>
|
||||
function test_gettersetter(property, oldresult, newval, newresult, oldurl, newurl) {
|
||||
var a = document.querySelector('a');
|
||||
a.href = oldurl;
|
||||
var r1 = a[property];
|
||||
assert_equals(r1, oldresult);
|
||||
a[property] = newval;
|
||||
var r2 = a[property];
|
||||
assert_equals(r2, newresult);
|
||||
var r3 = a.href;
|
||||
assert_equals(r3, newurl);
|
||||
}
|
||||
|
||||
//Elements for each test: [property, oldresult, newvalue, newresult, oldurl, newurl]
|
||||
// [0] [1] [2] [3] [4] [5]
|
||||
tests = [
|
||||
["hash", "#somehash", "someother", "#someother",
|
||||
"http://google.com/index.html#somehash",
|
||||
"http://google.com/index.html#someother"],
|
||||
["hash", "#somehash", "#someother", "#someother",
|
||||
"http://google.com/index.html#somehash",
|
||||
"http://google.com/index.html#someother"],
|
||||
["host", "google.com:1234", "github.com:4444", "github.com:4444",
|
||||
"http://google.com:1234/somedir",
|
||||
"http://github.com:4444/somedir"],
|
||||
["hostname", "google.com", "github.com", "github.com",
|
||||
"http://google.com:1234/somedir",
|
||||
"http://github.com:1234/somedir"],
|
||||
["href", "http://google.com:1234/somedir", "http://goo-gle.com:1234/other/x.html", "http://goo-gle.com:1234/other/x.html",
|
||||
"http://google.com:1234/somedir",
|
||||
"http://goo-gle.com:1234/other/x.html"],
|
||||
["password", "flabada", "blubb", "blubb",
|
||||
"https://anonymous:flabada@developer.mozilla.org/en-US/docs/",
|
||||
"https://anonymous:blubb@developer.mozilla.org/en-US/docs/"],
|
||||
["pathname", "/somedir/someotherdir/index.html", "/newpath/x.txt", "/newpath/x.txt",
|
||||
"http://google.com:1234/somedir/someotherdir/index.html",
|
||||
"http://google.com:1234/newpath/x.txt"],
|
||||
["port", "1234", "4444", "4444", "http://google.com:1234/somedir", "http://google.com:4444/somedir"],
|
||||
["protocol", "http:", "ftp:", "ftp:", "http://google.com/somedir", "ftp://google.com/somedir"],
|
||||
["protocol", "http:", "ftp", "ftp:", "http://google.com/somedir", "ftp://google.com/somedir"],
|
||||
["search", "?ho", "?hi", "?hi", "http://google.com/q.php?ho", "http://google.com/q.php?hi"],
|
||||
["search", "?ho", "hi", "?hi", "http://google.com/q.php?ho", "http://google.com/q.php?hi"],
|
||||
["search", "?ho", "?hi", "?hi", "http://google.com/?ho", "http://google.com/?hi"],
|
||||
["search", "?ho", "hi", "?hi", "http://google.com/?ho", "http://google.com/?hi"],
|
||||
["username", "anonymous", "wellknown", "wellknown",
|
||||
"https://anonymous:pwd@developer.mozilla.org:1234/en-US/",
|
||||
"https://wellknown:pwd@developer.mozilla.org:1234/en-US/"]
|
||||
];
|
||||
|
||||
for (var i = 0; i < tests.length; i++) {
|
||||
test(function() {
|
||||
test_gettersetter(tests[i][0], tests[i][1], tests[i][2], tests[i][3], tests[i][4], tests[i][5])
|
||||
}, "Getter and setter for attribute of anchor element(" + i + "):" + tests[i][0] );
|
||||
}
|
||||
</script>
|
||||
</head>
|
||||
</html>
|
Loading…
Add table
Add a link
Reference in a new issue