Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-09-19 19:30:10 +01:00
Code Issues Projects Releases Packages Wiki Activity

libservo: Remove Opts::webrender_stats and -Z wr-stats (#39331)

Browse source 
This option is supported via the WebView API now and you can enable it
in servoshell by pressing `Ctrl` + `F12`. The command-line argument and
`Opts` field are older and I believe are no longer necessary.

Testing: This just removes a redundant command-line option, so no tests.

Signed-off-by: Martin Robinson <mrobinson@igalia.com>
This commit is contained in:
Martin Robinson 2025-09-17 13:58:16 +02:00 • committed by GitHub
parent eaca68472b
commit 5505d00334
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 1 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

4
components/config/opts.rs
View file

@ -134,9 +134,6 @@ pub struct DebugOptions {
/// Log GC passes and their durations. /// Log GC passes and their durations.
pub gc_profile: bool, pub gc_profile: bool,
/// Show webrender profiling stats on screen.
pub webrender_stats: bool,
/// True to use OS native signposting facilities. This makes profiling events (script activity, /// True to use OS native signposting facilities. This makes profiling events (script activity,
/// reflow, compositing, etc.) appear in Instruments.app on macOS. /// reflow, compositing, etc.) appear in Instruments.app on macOS.
pub signpost: bool, pub signpost: bool,
@ -160,7 +157,6 @@ impl DebugOptions {
"relayout-event" => self.relayout_event = true, "relayout-event" => self.relayout_event = true,
"signpost" => self.signpost = true, "signpost" => self.signpost = true,
"dump-style-stats" => self.dump_style_statistics = true, "dump-style-stats" => self.dump_style_statistics = true,
"wr-stats" => self.webrender_stats = true,
"" => {}, "" => {},
_ => return Err(String::from(option)), _ => return Err(String::from(option)),
}; };

8
components/servo/lib.rs
View file

@ -315,12 +315,6 @@ impl Servo {
}; };
let (mut webrender, webrender_api_sender) = { let (mut webrender, webrender_api_sender) = {
let mut debug_flags = webrender::DebugFlags::empty();
debug_flags.set(
webrender::DebugFlags::PROFILER_DBG,
opts.debug.webrender_stats,
);
rendering_context.prepare_for_rendering(); rendering_context.prepare_for_rendering();
let render_notifier = Box::new(RenderNotifier::new(compositor_proxy.clone())); let render_notifier = Box::new(RenderNotifier::new(compositor_proxy.clone()));
let clear_color = servo_config::pref!(shell_background_color_rgba); let clear_color = servo_config::pref!(shell_background_color_rgba);
@ -359,7 +353,7 @@ impl Servo {
// See: https://github.com/servo/servo/issues/31726 // See: https://github.com/servo/servo/issues/31726
use_optimized_shaders: true, use_optimized_shaders: true,
resource_override_path: opts.shaders_dir.clone(), resource_override_path: opts.shaders_dir.clone(),
debug_flags, debug_flags: webrender::DebugFlags::empty(),
precache_flags: if pref!(gfx_precache_shaders) { precache_flags: if pref!(gfx_precache_shaders) {
ShaderPrecacheFlags::FULL_COMPILE ShaderPrecacheFlags::FULL_COMPILE
} else { } else {

1
ports/servoshell/prefs.rs
View file

@ -793,7 +793,6 @@ fn print_debug_options_usage(app: &str) {
"signpost", "signpost",
"Emit native OS signposts for profile events (currently macOS only)", "Emit native OS signposts for profile events (currently macOS only)",
); );
print_option("wr-stats", "Show WebRender profiler on screen.");
println!(); println!();