From 557ce73f5f8acf7f97c49ff0e50c8cdc8b0f178d Mon Sep 17 00:00:00 2001 From: Delan Azabani Date: Thu, 23 Mar 2023 19:15:20 +0800 Subject: [PATCH] add spec issue as todo in [[OwnPropertyKeys]] trap --- components/script/window_named_properties.rs | 3 +++ 1 file changed, 3 insertions(+) diff --git a/components/script/window_named_properties.rs b/components/script/window_named_properties.rs index 0165e2de625..46cf61d7c2e 100644 --- a/components/script/window_named_properties.rs +++ b/components/script/window_named_properties.rs @@ -151,6 +151,9 @@ unsafe extern "C" fn own_property_keys( _proxy: HandleObject, props: MutableHandleIdVector, ) -> bool { + // TODO is this all we need to return? compare with gecko: + // https://searchfox.org/mozilla-central/rev/af78418c4b5f2c8721d1a06486cf4cf0b33e1e8d/dom/base/WindowNamedPropertiesHandler.cpp#175-232 + // see also https://github.com/whatwg/html/issues/9068 rooted!(in(cx) let mut rooted = SymbolId(GetWellKnownSymbol(cx, SymbolCode::toStringTag))); AppendToIdVector(props, rooted.handle().into()); true