Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-06 14:10:11 +01:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #17501 - jyc:Text-children_changed, r=emilio

Browse source 
Have CharacterData call children_changed on its parent when data is set.

**Can't run WPT on my computer, so pushing here to run tests 😢**

Have CharacterData.SetData call children_changed on its parent when
data is set (if it is a Text node) so that HTMLStyleElement parents can
re-parse. Add variant ChildrenMutation::Text for it to use as the
mutation.

This fixes an issue where an empty <style> element's data is set but the
style is not updated. An HTMLStyleElement parent re-parses in its
children_changed implementation.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes are part of a series to fix #17182 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17501)
<!-- Reviewable:end -->
This commit is contained in:
bors-servo 2017-07-13 14:00:13 -07:00 • committed by GitHub
commit 559c0d1d90
8 changed files with 24 additions and 301 deletions
Download patch file Download diff file Expand all files Collapse all files

22
tests/wpt/metadata-css/cssom-1_dev/html/selectorSerialize.htm.ini
View file

@ -3,24 +3,6 @@
[:nth-child serialization produces canonical form]
expected: FAIL
[single universal selector shows '*' when serialized.]
expected: FAIL
[single type (simple) selector in the sequence of simple selectors that is not a universal selector]
expected: FAIL
[single class (simple) selector in the sequence of simple selectors that is not a universal selector]
expected: FAIL
[single id (simple) selector in the sequence of simple selectors that is not a universal selector]
expected: FAIL
[single pseudo (simple) selector which does not accept arguments in the sequence of simple selectors that is not a universal selector]
expected: FAIL
[single pseudo (simple) selector "lang" which accepts arguments in the sequence of simple selectors that is not a universal selector]
expected: FAIL
[single pseudo (simple) selector "nth-child" which accepts arguments in the sequence of simple selectors that is not a universal selector]
expected: FAIL
@ -32,7 +14,3 @@
[single pseudo (simple) selector ":nth-last-of-type" which accepts arguments in the sequence of simple selectors that is not a universal selector]
expected: FAIL
[single pseudo (simple) selector ":not" which accepts arguments in the sequence of simple selectors that is not a universal selector]
expected: FAIL

93
tests/wpt/metadata-css/cssom-1_dev/html/serialize-namespaced-type-selectors.htm.ini
View file

@ -1,59 +1,11 @@
[serialize-namespaced-type-selectors.htm]
type: testharness
[Simple type selector]
expected: FAIL
[Type selector without a namespace]
expected: FAIL
[Type selector with any namespace]
expected: FAIL
[Universal selector]
expected: FAIL
[Universal selector without a namespace]
expected: FAIL
[Universal selector in any namespace]
expected: FAIL
[Type selector with namespace]
expected: FAIL
[Universal selector with namespace]
expected: FAIL
[Simple type selector followed by class]
expected: FAIL
[Simple type selector followed by id]
expected: FAIL
[Simple type selector followed by pseudo class]
expected: FAIL
[Simple type selector followed by pseudo element]
expected: FAIL
[Simple type selector followed by atttribute selector]
expected: FAIL
[Type selector without a namespace followed by class]
expected: FAIL
[Type selector without a namespace followed by id]
expected: FAIL
[Type selector without a namespace followed by pseudo class]
expected: FAIL
[Type selector without a namespace followed by pseudo element]
expected: FAIL
[Type selector without a namespace followed by attribute selector]
expected: FAIL
[Type selector with any namespace followed by class]
expected: FAIL
@ -84,21 +36,6 @@
[Universal selector followed by attribute selector]
expected: FAIL
[Universal selector without a namespace followed by class]
expected: FAIL
[Universal selector without a namespace followed by id]
expected: FAIL
[Universal selector without a namespace followed by pseudo class]
expected: FAIL
[Universal selector without a namespace followed by pseudo element]
expected: FAIL
[Universal selector without a namespace followed by attribute selector]
expected: FAIL
[Universal selector in any namespace followed by class]
expected: FAIL
@ -114,36 +51,6 @@
[Universal selector in any namespace followed by attribute selector]
expected: FAIL
[Type selector with namespace followed by class]
expected: FAIL
[Type selector with namespace followed by id]
expected: FAIL
[Type selector with namespace followed by pseudo class]
expected: FAIL
[Type selector with namespace followed by pseudo element]
expected: FAIL
[Type selector with namespace followed by attribute selector]
expected: FAIL
[Universal selector with namespace followed by class]
expected: FAIL
[Universal selector with namespace followed by id]
expected: FAIL
[Universal selector with namespace followed by pseudo class]
expected: FAIL
[Universal selector with namespace followed by pseudo element]
expected: FAIL
[Universal selector with namespace followed by attribute selector]
expected: FAIL
[Type selector with namespace equal to default namespace]
expected: FAIL