From 55c65d319272b84197cb80edce388fd5ae601ed8 Mon Sep 17 00:00:00 2001 From: Corey Farwell Date: Fri, 9 Oct 2015 10:45:24 -0400 Subject: [PATCH] Implement 'align' attribute for
elements --- components/script/dom/htmldivelement.rs | 10 +- .../script/dom/webidls/HTMLDivElement.webidl | 2 +- .../wpt/metadata/html/dom/interfaces.html.ini | 6 - .../html/dom/reflection-grouping.html.ini | 129 ------------------ 4 files changed, 10 insertions(+), 137 deletions(-) diff --git a/components/script/dom/htmldivelement.rs b/components/script/dom/htmldivelement.rs index d5979f2c16b..b2e6a2882bf 100644 --- a/components/script/dom/htmldivelement.rs +++ b/components/script/dom/htmldivelement.rs @@ -2,7 +2,7 @@ * License, v. 2.0. If a copy of the MPL was not distributed with this * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ -use dom::bindings::codegen::Bindings::HTMLDivElementBinding; +use dom::bindings::codegen::Bindings::HTMLDivElementBinding::{self, HTMLDivElementMethods}; use dom::bindings::codegen::InheritTypes::HTMLDivElementDerived; use dom::bindings::js::Root; use dom::document::Document; @@ -42,3 +42,11 @@ impl HTMLDivElement { Node::reflect_node(box element, document, HTMLDivElementBinding::Wrap) } } + +impl HTMLDivElementMethods for HTMLDivElement { + // https://html.spec.whatwg.org/multipage/#dom-div-align + make_getter!(Align); + + // https://html.spec.whatwg.org/multipage/#dom-div-align + make_setter!(SetAlign, "align"); +} diff --git a/components/script/dom/webidls/HTMLDivElement.webidl b/components/script/dom/webidls/HTMLDivElement.webidl index 1e1319fe573..2751c65af26 100644 --- a/components/script/dom/webidls/HTMLDivElement.webidl +++ b/components/script/dom/webidls/HTMLDivElement.webidl @@ -10,5 +10,5 @@ interface HTMLDivElement : HTMLElement { // https://www.whatwg.org/html/#HTMLDivElement-partial partial interface HTMLDivElement { - // attribute DOMString align; + attribute DOMString align; }; diff --git a/tests/wpt/metadata/html/dom/interfaces.html.ini b/tests/wpt/metadata/html/dom/interfaces.html.ini index 9a528a172da..9c80af54ed9 100644 --- a/tests/wpt/metadata/html/dom/interfaces.html.ini +++ b/tests/wpt/metadata/html/dom/interfaces.html.ini @@ -2457,12 +2457,6 @@ [HTMLDivElement interface: existence and properties of interface object] expected: FAIL - [HTMLDivElement interface: attribute align] - expected: FAIL - - [HTMLDivElement interface: document.createElement("div") must inherit property "align" with the proper type (0)] - expected: FAIL - [HTMLAnchorElement interface: existence and properties of interface object] expected: FAIL diff --git a/tests/wpt/metadata/html/dom/reflection-grouping.html.ini b/tests/wpt/metadata/html/dom/reflection-grouping.html.ini index f3b4d3465ea..74f632a737c 100644 --- a/tests/wpt/metadata/html/dom/reflection-grouping.html.ini +++ b/tests/wpt/metadata/html/dom/reflection-grouping.html.ini @@ -12252,135 +12252,6 @@ [div.tabIndex: IDL set to -2147483648 followed by getAttribute()] expected: FAIL - [div.align: typeof IDL attribute] - expected: FAIL - - [div.align: IDL get with DOM attribute unset] - expected: FAIL - - [div.align: setAttribute() to "" followed by IDL get] - expected: FAIL - - [div.align: setAttribute() to " \\0\\x01\\x02\\x03\\x04\\x05\\x06\\x07 \\b\\t\\n\\v\\f\\r\\x0e\\x0f \\x10\\x11\\x12\\x13\\x14\\x15\\x16\\x17 \\x18\\x19\\x1a\\x1b\\x1c\\x1d\\x1e\\x1f foo " followed by IDL get] - expected: FAIL - - [div.align: setAttribute() to undefined followed by IDL get] - expected: FAIL - - [div.align: setAttribute() to 7 followed by IDL get] - expected: FAIL - - [div.align: setAttribute() to 1.5 followed by IDL get] - expected: FAIL - - [div.align: setAttribute() to true followed by IDL get] - expected: FAIL - - [div.align: setAttribute() to false followed by IDL get] - expected: FAIL - - [div.align: setAttribute() to object "[object Object\]" followed by IDL get] - expected: FAIL - - [div.align: setAttribute() to NaN followed by IDL get] - expected: FAIL - - [div.align: setAttribute() to Infinity followed by IDL get] - expected: FAIL - - [div.align: setAttribute() to -Infinity followed by IDL get] - expected: FAIL - - [div.align: setAttribute() to "\\0" followed by IDL get] - expected: FAIL - - [div.align: setAttribute() to null followed by IDL get] - expected: FAIL - - [div.align: setAttribute() to object "test-toString" followed by IDL get] - expected: FAIL - - [div.align: setAttribute() to object "test-valueOf" followed by IDL get] - expected: FAIL - - [div.align: IDL set to "" followed by getAttribute()] - expected: FAIL - - [div.align: IDL set to " \\0\\x01\\x02\\x03\\x04\\x05\\x06\\x07 \\b\\t\\n\\v\\f\\r\\x0e\\x0f \\x10\\x11\\x12\\x13\\x14\\x15\\x16\\x17 \\x18\\x19\\x1a\\x1b\\x1c\\x1d\\x1e\\x1f foo " followed by getAttribute()] - expected: FAIL - - [div.align: IDL set to undefined followed by getAttribute()] - expected: FAIL - - [div.align: IDL set to undefined followed by IDL get] - expected: FAIL - - [div.align: IDL set to 7 followed by getAttribute()] - expected: FAIL - - [div.align: IDL set to 7 followed by IDL get] - expected: FAIL - - [div.align: IDL set to 1.5 followed by getAttribute()] - expected: FAIL - - [div.align: IDL set to 1.5 followed by IDL get] - expected: FAIL - - [div.align: IDL set to true followed by getAttribute()] - expected: FAIL - - [div.align: IDL set to true followed by IDL get] - expected: FAIL - - [div.align: IDL set to false followed by getAttribute()] - expected: FAIL - - [div.align: IDL set to false followed by IDL get] - expected: FAIL - - [div.align: IDL set to object "[object Object\]" followed by getAttribute()] - expected: FAIL - - [div.align: IDL set to object "[object Object\]" followed by IDL get] - expected: FAIL - - [div.align: IDL set to NaN followed by getAttribute()] - expected: FAIL - - [div.align: IDL set to NaN followed by IDL get] - expected: FAIL - - [div.align: IDL set to Infinity followed by getAttribute()] - expected: FAIL - - [div.align: IDL set to Infinity followed by IDL get] - expected: FAIL - - [div.align: IDL set to -Infinity followed by getAttribute()] - expected: FAIL - - [div.align: IDL set to -Infinity followed by IDL get] - expected: FAIL - - [div.align: IDL set to "\\0" followed by getAttribute()] - expected: FAIL - - [div.align: IDL set to null followed by getAttribute()] - expected: FAIL - - [div.align: IDL set to null followed by IDL get] - expected: FAIL - - [div.align: IDL set to object "test-toString" followed by getAttribute()] - expected: FAIL - - [div.align: IDL set to object "test-toString" followed by IDL get] - expected: FAIL - - [div.align: IDL set to object "test-valueOf" followed by IDL get] - expected: FAIL - [div.itemScope: typeof IDL attribute] expected: FAIL