Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-15 18:35:33 +01:00
Code Issues Projects Releases Packages Wiki Activity

layout: Add initial support for bidirectional text (BiDi) (#33148)

Browse source 
This adds supports for right-to-left text assigning bidi levels to all
line items when necessary. This includes support for the `dir` attribute
as well as corresponding CSS properties like `unicode-bidi`. It only
implements right-to-left rendering for inline layout at the moment and
doesn't include support for `dir=auto`. Because of missing features,
this causes quite a few tests to start failing, as references become
incorrect due to right-to-left rendering being active in some cases,
but not others (before it didn't exist at all).

Analysis of most of the new failures:

```
- /css/css-flexbox/gap-001-rtl.html
  /css/css-flexbox/gap-004-rtl.html
 - Require implementing BiDi in Flexbox, because the start and
   end inline margins are opposite the order of items.

- /css/CSS2/bidi-text/direction-applies-to-*.xht
  /css/CSS2/bidi-text/direction-applies-to-002.xht
  /css/CSS2/bidi-text/direction-applies-to-003.xht
  /css/CSS2/bidi-text/direction-applies-to-004.xht
  - Broken due to a bug in tables, not allocating the
    right amount of width for a column.

- /css/css-lists/inline-list.html
  - This fails because we wrongly insert a soft wrap opportunity between the
    start of an inline box and its first content.

- /css/css-text/bidi/bidi-lines-001.html
  /css/css-text/bidi/bidi-lines-002.html
  /css/CSS2/text/bidi-flag-emoji.html
  - We do not fully support unicode-bidi: plaintext

- /css/css-text/text-align/text-align-end-010.html
  /css/css-text/text-align/text-align-justify-006.html
  /css/css-text/text-align/text-align-start-010.html
  /html/dom/elements/global-attributes/*
  - We do not support dir=auto yet.

- /css/css-text/white-space/tab-bidi-001.html
  - Servo doesn't support tab stops

- /css/CSS2/positioning/abspos-block-level-001.html
  /css/css-text/word-break/word-break-normal-ar-000.html
  - Do not yet support RTL layout in block

- /css/css-text/white-space/pre-wrap-018.html
  - Even in RTL contexts, spaces at the end of the line must hang and
    not be reordered

- /css/css-text/white-space/trailing-space-and-text-alignment-rtl-002.html
  - We are letting spaces hang with white-space: pre, but they shouldn't
    hang.
```

Signed-off-by: Martin Robinson <mrobinson@igalia.com>
Co-authored-by: Rakhi Sharma <atbrakhi@igalia.com>
This commit is contained in:
Martin Robinson 2024-08-21 07:28:54 -07:00 • committed by GitHub
parent 65bd5a3b99
commit 56280c6242
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
189 changed files with 547 additions and 762 deletions
Download patch file Download diff file Expand all files Collapse all files

2
tests/wpt/meta/css/CSS2/bidi-text/bidi-box-model-006.xht.ini vendored
View file

@ -1,2 +0,0 @@
[bidi-box-model-006.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/bidi-text/bidi-breaking-001.xht.ini vendored
View file

@ -1,2 +0,0 @@
[bidi-breaking-001.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/bidi-text/bidi-breaking-002.xht.ini vendored
View file

@ -1,2 +0,0 @@
[bidi-breaking-002.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/bidi-text/bidi-glyph-mirroring-002.xht.ini vendored
View file

@ -1,2 +0,0 @@
[bidi-glyph-mirroring-002.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/bidi-text/bidi-inline-001.xht.ini vendored
View file

@ -1,2 +0,0 @@
[bidi-inline-001.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/bidi-text/bidi-inline-002.xht.ini vendored
View file

@ -1,2 +0,0 @@
[bidi-inline-002.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/bidi-text/direction-002.xht.ini vendored
View file

@ -1,2 +0,0 @@
[direction-002.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/bidi-text/direction-003.xht.ini vendored
View file

@ -1,2 +0,0 @@
[direction-003.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/bidi-text/direction-applies-to-001.xht.ini vendored Normal file
View file

@ -0,0 +1,2 @@
[direction-applies-to-001.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/bidi-text/direction-applies-to-002.xht.ini vendored Normal file
View file

@ -0,0 +1,2 @@
[direction-applies-to-002.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/bidi-text/direction-applies-to-003.xht.ini vendored Normal file
View file

@ -0,0 +1,2 @@
[direction-applies-to-003.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/bidi-text/direction-applies-to-004.xht.ini vendored Normal file
View file

@ -0,0 +1,2 @@
[direction-applies-to-004.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/bidi-text/direction-applies-to-007.xht.ini vendored
View file

@ -1,2 +0,0 @@
[direction-applies-to-007.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/bidi-text/direction-applies-to-008.xht.ini vendored
View file

@ -1,2 +0,0 @@
[direction-applies-to-008.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/bidi-text/direction-applies-to-009.xht.ini vendored
View file

@ -1,2 +0,0 @@
[direction-applies-to-009.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/bidi-text/direction-applies-to-012.xht.ini vendored
View file

@ -1,2 +0,0 @@
[direction-applies-to-012.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/bidi-text/direction-applies-to-013.xht.ini vendored
View file

@ -1,2 +0,0 @@
[direction-applies-to-013.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/bidi-text/direction-applies-to-014.xht.ini vendored
View file

@ -1,2 +0,0 @@
[direction-applies-to-014.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/bidi-text/direction-applies-to-015.xht.ini vendored
View file

@ -1,2 +0,0 @@
[direction-applies-to-015.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/bidi-text/line-breaking-bidi-003.xht.ini vendored Normal file
View file

@ -0,0 +1,2 @@
[line-breaking-bidi-003.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/bidi-text/unicode-bidi-001.xht.ini vendored
View file

@ -1,2 +0,0 @@
[unicode-bidi-001.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/bidi-text/unicode-bidi-002.xht.ini vendored
View file

@ -1,2 +0,0 @@
[unicode-bidi-002.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/bidi-text/unicode-bidi-applies-to-008.xht.ini vendored
View file

@ -1,2 +0,0 @@
[unicode-bidi-applies-to-008.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/generated-content/bidi-generated-content-001.xht.ini vendored
View file

@ -1,2 +0,0 @@
[bidi-generated-content-001.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/generated-content/bidi-generated-content-002.xht.ini vendored
View file

@ -1,2 +0,0 @@
[bidi-generated-content-002.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/linebox/inline-formatting-context-023.xht.ini vendored
View file

@ -1,2 +0,0 @@
[inline-formatting-context-023.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/bidi-text/bidi-001.xht.ini → tests/wpt/meta/css/CSS2/normal-flow/blocks-018.xht.ini vendored
View file

@ -1,2 +1,2 @@
[bidi-001.xht]
[blocks-018.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/bidi-text/bidi-002.xht.ini → tests/wpt/meta/css/CSS2/normal-flow/blocks-019.xht.ini vendored
View file

@ -1,2 +1,2 @@
[bidi-002.xht]
[blocks-019.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/normal-flow/replaced-intrinsic-002.xht.ini vendored Normal file
View file

@ -0,0 +1,2 @@
[replaced-intrinsic-002.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/positioning/abspos-block-level-001.html.ini vendored Normal file
View file

@ -0,0 +1,2 @@
[abspos-block-level-001.html]
expected: FAIL

2
tests/wpt/meta/css/CSS2/positioning/left-offset-003.xht.ini vendored
View file

@ -1,2 +0,0 @@
[left-offset-003.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/positioning/left-offset-percentage-001.xht.ini vendored
View file

@ -1,2 +0,0 @@
[left-offset-percentage-001.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/text/bidi-flag-emoji.html.ini vendored Normal file
View file

@ -0,0 +1,2 @@
[bidi-flag-emoji.html]
expected: FAIL

2
tests/wpt/meta/css/CSS2/text/text-align-white-space-006.xht.ini vendored
View file

@ -1,2 +0,0 @@
[text-align-white-space-006.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/text/text-align-white-space-008.xht.ini vendored
View file

@ -1,2 +0,0 @@
[text-align-white-space-008.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/text/text-indent-rtl-002.xht.ini vendored
View file

@ -1,2 +0,0 @@
[text-indent-rtl-002.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/text/white-space-bidirectionality-001.xht.ini vendored
View file

@ -1,2 +0,0 @@
[white-space-bidirectionality-001.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/text/white-space-collapsing-bidi-002.xht.ini vendored
View file

@ -1,2 +0,0 @@
[white-space-collapsing-bidi-002.xht]
expected: FAIL

2
tests/wpt/meta/css/CSS2/visuren/inline-formatting-context-001.xht.ini vendored
View file

@ -1,2 +0,0 @@
[inline-formatting-context-001.xht]
expected: FAIL