Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-06-06 16:45:39 +00:00
Code Issues Projects Releases Packages Wiki Activity

Clippy: Fixed some clippy warnings (#31818)

Browse source 
* Fixed clippy warnings

* made changes for lowercase characters.

* changed is_lowercase() to is_ascii_lowercase()

* added std library function `is_ascii_uppercase()` and `is_ascii_lowercase()`

* made recommended changes
This commit is contained in:
Aarya Khandelwal 2024-03-23 18:18:49 +05:30 • committed by GitHub
parent 3c05b58221
commit 566fd475d9
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
11 changed files with 57 additions and 68 deletions
Download patch file Download diff file Expand all files Collapse all files

21
components/script/dom/htmlformelement.rs
View file

@ -180,7 +180,7 @@ impl HTMLFormElement {
.iter()
.filter(|n| HTMLFormElement::filter_for_radio_list(mode, n, name))
.nth(index as usize)
.and_then(|n| Some(DomRoot::from_ref(n.upcast::<Node>())))
.map(|n| DomRoot::from_ref(n.upcast::<Node>()))
}
pub fn count_for_radio_list(&self, mode: RadioListMode, name: &Atom) -> u32 {
@ -441,14 +441,14 @@ impl HTMLFormElementMethods for HTMLFormElement {
past_names_map.insert(
name,
(
Dom::from_ref(&*element_node.downcast::<Element>().unwrap()),
Dom::from_ref(element_node.downcast::<Element>().unwrap()),
NoTrace(Instant::now()),
),
);
// Step 6
return Some(RadioNodeListOrElement::Element(DomRoot::from_ref(
&*element_node.downcast::<Element>().unwrap(),
element_node.downcast::<Element>().unwrap(),
)));
}
@ -486,10 +486,7 @@ impl HTMLFormElementMethods for HTMLFormElement {
impl SourcedNameSource {
fn is_past(&self) -> bool {
match self {
SourcedNameSource::Past(..) => true,
_ => false,
}
matches!(self, SourcedNameSource::Past(..))
}
}
@ -512,7 +509,7 @@ impl HTMLFormElementMethods for HTMLFormElement {
if let Some(id_atom) = child.get_id() {
let entry = SourcedName {
name: id_atom,
element: DomRoot::from_ref(&*child),
element: DomRoot::from_ref(child),
source: SourcedNameSource::Id,
};
sourced_names_vec.push(entry);
@ -520,7 +517,7 @@ impl HTMLFormElementMethods for HTMLFormElement {
if let Some(name_atom) = child.get_name() {
let entry = SourcedName {
name: name_atom,
element: DomRoot::from_ref(&*child),
element: DomRoot::from_ref(child),
source: SourcedNameSource::Name,
};
sourced_names_vec.push(entry);
@ -534,7 +531,7 @@ impl HTMLFormElementMethods for HTMLFormElement {
if let Some(id_atom) = child.get_id() {
let entry = SourcedName {
name: id_atom,
element: DomRoot::from_ref(&*child),
element: DomRoot::from_ref(child),
source: SourcedNameSource::Id,
};
sourced_names_vec.push(entry);
@ -542,7 +539,7 @@ impl HTMLFormElementMethods for HTMLFormElement {
if let Some(name_atom) = child.get_name() {
let entry = SourcedName {
name: name_atom,
element: DomRoot::from_ref(&*child),
element: DomRoot::from_ref(child),
source: SourcedNameSource::Name,
};
sourced_names_vec.push(entry);
@ -612,7 +609,7 @@ impl HTMLFormElementMethods for HTMLFormElement {
}
}
return names_vec;
names_vec
}
/// <https://html.spec.whatwg.org/multipage/#dom-form-checkvalidity>