Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-03 04:30:10 +01:00
Code Issues Projects Releases Packages Wiki Activity

compositor: Always send an animating tick when a pipeline starts animating (#37507)

Browse source 
Instead of taking into account whether the entire WebView starts
animating, always send an animation tick when a pipeline moves from the
"not animating" to "animating" state. It could be that the WebView was
animating, but not painting if the animation was not producing display
lists. In that case, the required tick would never come, because it is
sent after a repaint.

Testing: Added a new WPT test.
Fixes: #37458.

Signed-off-by: Martin Robinson <mrobinson@igalia.com>
Co-authored-by: Oriol Brufau <obrufau@igalia.com>
This commit is contained in:
Martin Robinson 2025-06-17 19:47:42 +02:00 • committed by GitHub
parent ded753f01b
commit 56e901d0c2
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 112 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

11
tests/wpt/meta/MANIFEST.json vendored
View file

@ -454483,6 +454483,10 @@
"59843ae54b64f6ce4f7e616d4be491c911ea84cf",
[]
],
"transition-in-iframe-001-iframe.html": [
"b7214bd378bd60b2729bc276bd775a389fd4ebcb",
[]
],
"two.gif": [
"01435c80209d533dc2164ac48279574c7ba4615e",
[]
@ -614633,6 +614637,13 @@
{}
]
],
"transition-in-iframe-001.html": [
"2e5e64de2308aa0c1f176c1d047cd178cac5d3ed",
[
null,
{}
]
],
"transition-property-001.html": [
"47a1417070f0c2e7b8171259d9c4f63c44e96bcc",
[

21
tests/wpt/tests/css/css-transitions/support/transition-in-iframe-001-iframe.html vendored Normal file
View file

@ -0,0 +1,21 @@
<!DOCTYPE html>
<html>
<body>
<style>
html {
background: red;
transition: all 0.1s;
}
</style>
<script>
window.addEventListener("message", () => {
document.documentElement.style.background = "green";
});
document.documentElement.addEventListener(
"transitionend", () => {
window.parent.postMessage("complete", "*");
}
);
</script>
</body>
</html>

54
tests/wpt/tests/css/css-transitions/transition-in-iframe-001.html vendored Normal file
View file

@ -0,0 +1,54 @@
<!DOCTYPE html>
<html>
<title>Transitions: Transition in &lt;iframe&gt; on page with empty rAF finishes</title>
<link rel="help" href="https://drafts.csswg.org/css-view-transitions-1/">
<link rel="author" href="mailto:mrobinson@igalia.com">
<link rel="author" href="mailto:obrufau@igalia.com">
<script src="/resources/testharness.js"></script>
<script src="/resources/testharnessreport.js"></script>
<script src="/common/rendering-utils.js"></script>
<style>
#iframe {
width: 100px;
height: 100px;
border: none;
}
</style>
<script>
let rAFId = null;
function triggerNeverEndingUselessRAF() {
rAFId = requestAnimationFrame(triggerNeverEndingUselessRAF);
}
promise_test(async t => {
await waitForAtLeastOneFrame();
await waitForAtLeastOneFrame();
let iframe = document.createElement("iframe");
iframe.id = "iframe";
iframe.src = "support/transition-in-iframe-001-iframe.html"
iframe.sandbox = "allow-scripts";
iframe.addEventListener("load", async () => {
await waitForAtLeastOneFrame();
await waitForAtLeastOneFrame();
iframe.contentWindow.postMessage("loaded", "*");
});
triggerNeverEndingUselessRAF();
document.body.appendChild(iframe);
await new Promise(resolve => {
window.addEventListener("message", () => {
cancelAnimationFrame(rAFId);
resolve();
});
});
});
</script>
</html>