diff --git a/.github/workflows/lint.yml b/.github/workflows/lint.yml index 808989555df..76116a59c34 100644 --- a/.github/workflows/lint.yml +++ b/.github/workflows/lint.yml @@ -51,9 +51,8 @@ jobs: sudo apt update python3 ./mach bootstrap # TODO: Do GitHub anotaions - # TODO: Fail on warnings - name: Clippy run: | - python3 ./mach cargo-clippy --use-crown --locked + python3 ./mach cargo-clippy --use-crown --locked -- -- --deny warnings - name: Tidy run: python3 ./mach test-tidy --no-progress --all \ No newline at end of file diff --git a/components/layout_2020/positioned.rs b/components/layout_2020/positioned.rs index eb7f83de978..90d0a2db5af 100644 --- a/components/layout_2020/positioned.rs +++ b/components/layout_2020/positioned.rs @@ -867,7 +867,7 @@ impl<'a> AbsoluteAxisSolver<'a> { // Override sizes let old_size = mem::replace(&mut self.computed_size, AuOrAuto::LengthPercentage(size)); let old_min_size = mem::replace(&mut self.computed_min_size, Au::zero()); - let old_max_size = mem::replace(&mut self.computed_max_size, None); + let old_max_size = self.computed_max_size.take(); let result = self.solve_tentatively();