Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-10 16:05:43 +01:00
Code Issues Projects Releases Packages Wiki Activity

Mark promise creation methods with CanGc (#33928)

Browse source 
* Add CanGc annotations to promise constructor.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Propagate CanGc arguments for Promise::new_in_current_realm.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Fix out-of-order entries.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Propagate CanGc from Promise::new.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Suppress clippy warning.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Formatting.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

---------

Signed-off-by: Josh Matthews <josh@joshmatthews.net>
This commit is contained in:
Josh Matthews 2024-10-22 05:35:20 -04:00 • committed by GitHub
parent edc304854f
commit 575e885529
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
50 changed files with 422 additions and 221 deletions
Download patch file Download diff file Expand all files Collapse all files

7
components/script/dom/gamepadhapticactuator.rs
View file

@ -144,8 +144,9 @@ impl GamepadHapticActuatorMethods for GamepadHapticActuator {
type_: GamepadHapticEffectType,
params: &GamepadEffectParameters,
comp: InRealm,
can_gc: CanGc,
) -> Rc<Promise> {
let playing_effect_promise = Promise::new_in_current_realm(comp);
let playing_effect_promise = Promise::new_in_current_realm(comp, can_gc);
// <https://www.w3.org/TR/gamepad/#dfn-valid-effect>
match type_ {
@ -258,8 +259,8 @@ impl GamepadHapticActuatorMethods for GamepadHapticActuator {
}
/// <https://www.w3.org/TR/gamepad/#dom-gamepadhapticactuator-reset>
fn Reset(&self, comp: InRealm) -> Rc<Promise> {
let promise = Promise::new_in_current_realm(comp);
fn Reset(&self, comp: InRealm, can_gc: CanGc) -> Rc<Promise> {
let promise = Promise::new_in_current_realm(comp, can_gc);
let document = self.global().as_window().Document();
if !document.is_fully_active() {