Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-03 04:30:10 +01:00
Code Issues Projects Releases Packages Wiki Activity

Mark promise creation methods with CanGc (#33928)

Browse source 
* Add CanGc annotations to promise constructor.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Propagate CanGc arguments for Promise::new_in_current_realm.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Fix out-of-order entries.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Propagate CanGc from Promise::new.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Suppress clippy warning.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Formatting.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

---------

Signed-off-by: Josh Matthews <josh@joshmatthews.net>
This commit is contained in:
Josh Matthews 2024-10-22 05:35:20 -04:00 • committed by GitHub
parent edc304854f
commit 575e885529
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
50 changed files with 422 additions and 221 deletions
Download patch file Download diff file Expand all files Collapse all files

9
components/script/dom/testbinding.rs
View file

@ -1013,6 +1013,7 @@ impl TestBindingMethods for TestBinding {
resolve: Option<Rc<SimpleCallback>>,
reject: Option<Rc<SimpleCallback>>,
comp: InRealm,
can_gc: CanGc,
) -> Rc<Promise> {
let global = self.global();
let handler = PromiseNativeHandler::new(
@ -1020,8 +1021,8 @@ impl TestBindingMethods for TestBinding {
resolve.map(SimpleHandler::new_boxed),
reject.map(SimpleHandler::new_boxed),
);
let p = Promise::new_in_current_realm(comp);
p.append_native_handler(&handler, comp);
let p = Promise::new_in_current_realm(comp, can_gc);
p.append_native_handler(&handler, comp, can_gc);
return p;
#[derive(JSTraceable, MallocSizeOf)]
@ -1042,8 +1043,8 @@ impl TestBindingMethods for TestBinding {
}
}
fn PromiseAttribute(&self, comp: InRealm) -> Rc<Promise> {
Promise::new_in_current_realm(comp)
fn PromiseAttribute(&self, comp: InRealm, can_gc: CanGc) -> Rc<Promise> {
Promise::new_in_current_realm(comp, can_gc)
}
fn AcceptPromise(&self, _promise: &Promise) {}