Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-06-06 16:45:39 +00:00
Code Issues Projects Releases Packages Wiki Activity

partially implemented SupportedPropertyNames

Browse source
This commit is contained in:
Anshul Jethvani 2019-12-06 19:52:10 -05:00
parent 159194b0f9
commit 575f7f5670
1 changed files with 26 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

28
components/script/dom/htmlformelement.rs
View file

@ -363,7 +363,8 @@ impl HTMLFormElementMethods for HTMLFormElement {
source: SourcedNameSource::Id,
};
sourcedNamesVec.push(entry);
} else if child.has_attribute(&local_name!("name")) {
}
if child.has_attribute(&local_name!("name")) {
let entry = SourcedName {
name: child.get_string_attribute(&local_name!("name")),
element: DomRoot::from_ref(&*child),
@ -384,7 +385,8 @@ impl HTMLFormElementMethods for HTMLFormElement {
source: SourcedNameSource::Id,
};
sourcedNamesVec.push(entry);
} else if child.has_attribute(&local_name!("name")) {
}
if child.has_attribute(&local_name!("name")) {
let entry = SourcedName {
name: child.get_string_attribute(&local_name!("name")),
element: DomRoot::from_ref(&*child),
@ -395,6 +397,28 @@ impl HTMLFormElementMethods for HTMLFormElement {
}
}
// Step 4
let past_names_map = self.past_names_map.borrow();
for (key, val) in past_names_map.iter() {
let entry = SourcedName {
name: key.clone(),
element: DomRoot::from_ref(&*val.0),
source: SourcedNameSource::Past(now()-val.1), // calculate difference now()-val.1 to find age
};
sourcedNamesVec.push(entry);
}
// Step 5
// TODO need to sort as per spec. This is a partially implemented function.
// Kindly guide us on how to refine this function further.
sourcedNamesVec.sort_by(|a, b| a.name.partial_cmp(&b.name).unwrap());
// Step 6
sourcedNamesVec.retain(|sn| !sn.name.to_string().is_empty());
// Step 7
// Q1. Unable to clearly understand. It seems to contradict with step 4.
// Step 8
let mut namesVec: Vec<DOMString> = Vec::new();
for elem in sourcedNamesVec.iter() {