From 57b0a3f23177f9318ec1164be30473eff99604c5 Mon Sep 17 00:00:00 2001 From: Gregory Terzian <2792687+gterzian@users.noreply.github.com> Date: Tue, 22 Apr 2025 14:49:18 +0800 Subject: [PATCH] Streams: fix writable transfer sink abort steps (#36638) Fixes an error where a promise was rejected where it should have been resolved. Follow-up to https://github.com/servo/servo/pull/36588/files#r2049437506; the initial diagnosis was wrong. Signed-off-by: gterzian <2792687+gterzian@users.noreply.github.com> --- components/script/dom/writablestreamdefaultcontroller.rs | 2 +- tests/wpt/meta/streams/transferable/writable-stream.html.ini | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/components/script/dom/writablestreamdefaultcontroller.rs b/components/script/dom/writablestreamdefaultcontroller.rs index 4e6a44b9f5a..751f5d8d976 100644 --- a/components/script/dom/writablestreamdefaultcontroller.rs +++ b/components/script/dom/writablestreamdefaultcontroller.rs @@ -555,7 +555,7 @@ impl WritableStreamDefaultController { promise.reject_error(error, can_gc); } else { // Otherwise, return a promise resolved with undefined. - promise.reject_native(&(), can_gc); + promise.resolve_native(&(), can_gc); } promise }, diff --git a/tests/wpt/meta/streams/transferable/writable-stream.html.ini b/tests/wpt/meta/streams/transferable/writable-stream.html.ini index 8e83ffc29e4..47326208f88 100644 --- a/tests/wpt/meta/streams/transferable/writable-stream.html.ini +++ b/tests/wpt/meta/streams/transferable/writable-stream.html.ini @@ -1,4 +1,3 @@ [writable-stream.html] - expected: ERROR [window.postMessage should be able to transfer a {readable, writable} pair] expected: FAIL