Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-05 13:40:08 +01:00
Code Issues Projects Releases Packages Wiki Activity

clippy: fix warnings in components/script (#32023)

Browse source
This commit is contained in:
Azhar Ismagulova 2024-04-09 10:34:52 +01:00 • committed by GitHub
parent 8d513cf4c7
commit 581913f77e
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
3 changed files with 18 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

2
components/script/dom/globalscope.rs
View file

@ -2826,7 +2826,7 @@ impl GlobalScope {
}, },
_ => { _ => {
p.reject_error(Error::NotSupported); p.reject_error(Error::NotSupported);
return p; p
}, },
} }
} }

16
components/script/dom/htmlinputelement.rs
View file

@ -708,11 +708,10 @@ impl HTMLInputElement {
}, },
}; };
} else { } else {
value = value + value += match dir {
match dir { StepDirection::Down => -f64::from(n) * allowed_value_step,
StepDirection::Down => -f64::from(n) * allowed_value_step, StepDirection::Up => f64::from(n) * allowed_value_step,
StepDirection::Up => f64::from(n) * allowed_value_step, };
};
} }
// Step 8 // Step 8
@ -2085,8 +2084,7 @@ impl HTMLInputElement {
if self.upcast::<Element>().click_in_progress() { if self.upcast::<Element>().click_in_progress() {
return; return;
} }
let submit_button; let submit_button = node
submit_button = node
.query_selector_iter(DOMString::from("input[type=submit]")) .query_selector_iter(DOMString::from("input[type=submit]"))
.unwrap() .unwrap()
.filter_map(DomRoot::downcast::<HTMLInputElement>) .filter_map(DomRoot::downcast::<HTMLInputElement>)
@ -2102,7 +2100,7 @@ impl HTMLInputElement {
} }
}, },
None => { None => {
let inputs = node let mut inputs = node
.query_selector_iter(DOMString::from("input")) .query_selector_iter(DOMString::from("input"))
.unwrap() .unwrap()
.filter_map(DomRoot::downcast::<HTMLInputElement>) .filter_map(DomRoot::downcast::<HTMLInputElement>)
@ -2125,7 +2123,7 @@ impl HTMLInputElement {
) )
}); });
if inputs.skip(1).next().is_some() { if inputs.nth(1).is_some() {
// lazily test for > 1 submission-blocking inputs // lazily test for > 1 submission-blocking inputs
return; return;
} }

19
components/script/serviceworker_manager.rs
View file

@ -497,17 +497,18 @@ impl ServiceWorkerManagerFactory for ServiceWorkerManager {
let from_constellation = ROUTER.route_ipc_receiver_to_new_crossbeam_receiver(receiver); let from_constellation = ROUTER.route_ipc_receiver_to_new_crossbeam_receiver(receiver);
let resource_port = ROUTER.route_ipc_receiver_to_new_crossbeam_receiver(resource_port); let resource_port = ROUTER.route_ipc_receiver_to_new_crossbeam_receiver(resource_port);
let _ = resource_sender.send(CoreResourceMsg::NetworkMediator(resource_chan, origin)); let _ = resource_sender.send(CoreResourceMsg::NetworkMediator(resource_chan, origin));
let swmanager_thread = move || {
ServiceWorkerManager::new(
own_sender,
from_constellation,
resource_port,
constellation_sender,
)
.handle_message()
};
if thread::Builder::new() if thread::Builder::new()
.name("SvcWorkerManager".to_owned()) .name("SvcWorkerManager".to_owned())
.spawn(move || { .spawn(swmanager_thread)
ServiceWorkerManager::new(
own_sender,
from_constellation,
resource_port,
constellation_sender,
)
.handle_message();
})
.is_err() .is_err()
{ {
warn!("ServiceWorkerManager thread spawning failed"); warn!("ServiceWorkerManager thread spawning failed");