mirror of
https://github.com/servo/servo.git
synced 2025-08-03 04:30:10 +01:00
style: Remove unit tests that test non-compliant stuff.
<position> no longer parses three values.
This commit is contained in:
Emilio Cobos Álvarez
parent
3da8f85914
commit
58d51b1e8c
2 changed files with 0 additions and 167 deletions
|
|
@ -36,27 +36,6 @@ where
|
|||
f(&context, &mut parser)
|
||||
}
|
||||
|
||||
fn parse_entirely<T, F>(f: F, s: &'static str) -> Result<T, ParseError<'static>>
|
||||
where
|
||||
F: for<'t> Fn(&ParserContext, &mut Parser<'static, 't>) -> Result<T, ParseError<'static>>,
|
||||
{
|
||||
let mut input = ParserInput::new(s);
|
||||
parse_entirely_input(f, &mut input)
|
||||
}
|
||||
|
||||
fn parse_entirely_input<'i: 't, 't, T, F>(
|
||||
f: F,
|
||||
input: &'t mut ParserInput<'i>,
|
||||
) -> Result<T, ParseError<'i>>
|
||||
where
|
||||
F: Fn(&ParserContext, &mut Parser<'i, 't>) -> Result<T, ParseError<'i>>,
|
||||
{
|
||||
parse_input(
|
||||
|context, parser| parser.parse_entirely(|p| f(context, p)),
|
||||
input,
|
||||
)
|
||||
}
|
||||
|
||||
// This is a macro so that the file/line information
|
||||
// is preserved in the panic
|
||||
macro_rules! assert_roundtrip_with_context {
|
||||
|
|
@ -141,7 +120,6 @@ mod effects;
|
|||
mod image;
|
||||
mod inherited_text;
|
||||
mod outline;
|
||||
mod position;
|
||||
mod selectors;
|
||||
mod supports;
|
||||
mod text_overflow;
|
||||
|
|
|
|||
|
|
@ -1,145 +0,0 @@
|
|||
/* This Source Code Form is subject to the terms of the Mozilla Public
|
||||
* License, v. 2.0. If a copy of the MPL was not distributed with this
|
||||
* file, You can obtain one at https://mozilla.org/MPL/2.0/. */
|
||||
|
||||
use crate::parsing::{parse, parse_entirely};
|
||||
use style::parser::Parse;
|
||||
use style::values::specified::position::*;
|
||||
use style_traits::ToCss;
|
||||
|
||||
#[test]
|
||||
fn test_position() {
|
||||
// Serialization is not actually specced
|
||||
// though these are the values expected by basic-shape
|
||||
// https://github.com/w3c/csswg-drafts/issues/368
|
||||
assert_roundtrip_with_context!(Position::parse, "center", "center center");
|
||||
assert_roundtrip_with_context!(Position::parse, "top left", "left top");
|
||||
assert_roundtrip_with_context!(Position::parse, "left top", "left top");
|
||||
assert_roundtrip_with_context!(Position::parse, "top right", "right top");
|
||||
assert_roundtrip_with_context!(Position::parse, "right top", "right top");
|
||||
assert_roundtrip_with_context!(Position::parse, "bottom left", "left bottom");
|
||||
assert_roundtrip_with_context!(Position::parse, "left bottom", "left bottom");
|
||||
assert_roundtrip_with_context!(Position::parse, "left center", "left center");
|
||||
assert_roundtrip_with_context!(Position::parse, "right center", "right center");
|
||||
assert_roundtrip_with_context!(Position::parse, "center top", "center top");
|
||||
assert_roundtrip_with_context!(Position::parse, "center bottom", "center bottom");
|
||||
assert_roundtrip_with_context!(Position::parse, "center 10px", "center 10px");
|
||||
assert_roundtrip_with_context!(Position::parse, "center 10%", "center 10%");
|
||||
assert_roundtrip_with_context!(Position::parse, "right 10%", "right 10%");
|
||||
|
||||
// Only keywords can be reordered
|
||||
assert!(parse_entirely(Position::parse, "top 40%").is_err());
|
||||
assert!(parse_entirely(Position::parse, "40% left").is_err());
|
||||
|
||||
// 3 and 4 value serialization
|
||||
assert_roundtrip_with_context!(Position::parse, "left 10px top 15px", "left 10px top 15px");
|
||||
assert_roundtrip_with_context!(Position::parse, "top 15px left 10px", "left 10px top 15px");
|
||||
assert_roundtrip_with_context!(Position::parse, "left 10% top 15px", "left 10% top 15px");
|
||||
assert_roundtrip_with_context!(Position::parse, "top 15px left 10%", "left 10% top 15px");
|
||||
assert_roundtrip_with_context!(Position::parse, "left top 15px", "left top 15px");
|
||||
assert_roundtrip_with_context!(Position::parse, "top 15px left", "left top 15px");
|
||||
assert_roundtrip_with_context!(Position::parse, "left 10px top", "left 10px top");
|
||||
assert_roundtrip_with_context!(Position::parse, "top left 10px", "left 10px top");
|
||||
assert_roundtrip_with_context!(Position::parse, "right 10px bottom", "right 10px bottom");
|
||||
assert_roundtrip_with_context!(Position::parse, "bottom right 10px", "right 10px bottom");
|
||||
assert_roundtrip_with_context!(Position::parse, "center right 10px", "right 10px center");
|
||||
assert_roundtrip_with_context!(Position::parse, "center bottom 10px", "center bottom 10px");
|
||||
|
||||
// Invalid 3 value positions
|
||||
assert!(parse_entirely(Position::parse, "20px 30px 20px").is_err());
|
||||
assert!(parse_entirely(Position::parse, "top 30px 20px").is_err());
|
||||
assert!(parse_entirely(Position::parse, "50% bottom 20%").is_err());
|
||||
|
||||
// Only horizontal and vertical keywords can have positions
|
||||
assert!(parse_entirely(Position::parse, "center 10px left 15px").is_err());
|
||||
assert!(parse_entirely(Position::parse, "center 10px 15px").is_err());
|
||||
assert!(parse_entirely(Position::parse, "center 10px bottom").is_err());
|
||||
|
||||
// "Horizontal Horizontal" or "Vertical Vertical" positions cause error
|
||||
assert!(parse_entirely(Position::parse, "left right").is_err());
|
||||
assert!(parse_entirely(Position::parse, "left 10px right").is_err());
|
||||
assert!(parse_entirely(Position::parse, "left 10px right 15%").is_err());
|
||||
assert!(parse_entirely(Position::parse, "top bottom").is_err());
|
||||
assert!(parse_entirely(Position::parse, "top 10px bottom").is_err());
|
||||
assert!(parse_entirely(Position::parse, "top 10px bottom 15%").is_err());
|
||||
|
||||
// Logical keywords are not supported in Position yet.
|
||||
assert!(parse(Position::parse, "x-start").is_err());
|
||||
assert!(parse(Position::parse, "y-end").is_err());
|
||||
assert!(parse(Position::parse, "x-start y-end").is_err());
|
||||
assert!(parse(Position::parse, "x-end 10px").is_err());
|
||||
assert!(parse(Position::parse, "y-start 20px").is_err());
|
||||
assert!(parse(Position::parse, "x-start bottom 10%").is_err());
|
||||
assert!(parse_entirely(Position::parse, "left y-start 10%").is_err());
|
||||
assert!(parse(Position::parse, "x-start 20px y-end 10%").is_err());
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn test_horizontal_position() {
|
||||
// One value serializations.
|
||||
assert_roundtrip_with_context!(HorizontalPosition::parse, "20px", "20px");
|
||||
assert_roundtrip_with_context!(HorizontalPosition::parse, "25%", "25%");
|
||||
assert_roundtrip_with_context!(HorizontalPosition::parse, "center", "center");
|
||||
assert_roundtrip_with_context!(HorizontalPosition::parse, "left", "left");
|
||||
assert_roundtrip_with_context!(HorizontalPosition::parse, "right", "right");
|
||||
|
||||
// Two value serializations.
|
||||
assert_roundtrip_with_context!(HorizontalPosition::parse, "right 10px", "right 10px");
|
||||
|
||||
// Invalid horizontal positions.
|
||||
assert!(parse(HorizontalPosition::parse, "top").is_err());
|
||||
assert!(parse(HorizontalPosition::parse, "bottom").is_err());
|
||||
assert!(parse(HorizontalPosition::parse, "y-start").is_err());
|
||||
assert!(parse(HorizontalPosition::parse, "y-end").is_err());
|
||||
assert!(parse(HorizontalPosition::parse, "y-end 20px ").is_err());
|
||||
assert!(parse(HorizontalPosition::parse, "bottom 20px").is_err());
|
||||
assert!(parse(HorizontalPosition::parse, "bottom top").is_err());
|
||||
assert!(parse_entirely(HorizontalPosition::parse, "20px y-end").is_err());
|
||||
assert!(parse_entirely(HorizontalPosition::parse, "20px top").is_err());
|
||||
assert!(parse_entirely(HorizontalPosition::parse, "left center").is_err());
|
||||
assert!(parse_entirely(HorizontalPosition::parse, "left top").is_err());
|
||||
assert!(parse_entirely(HorizontalPosition::parse, "left right").is_err());
|
||||
assert!(parse_entirely(HorizontalPosition::parse, "20px 30px").is_err());
|
||||
assert!(parse_entirely(HorizontalPosition::parse, "10px left").is_err());
|
||||
assert!(parse_entirely(HorizontalPosition::parse, "x-end 20%").is_err());
|
||||
assert!(parse_entirely(HorizontalPosition::parse, "20px x-start").is_err());
|
||||
|
||||
// Logical keywords are not supported in Position yet.
|
||||
assert!(parse(HorizontalPosition::parse, "x-start").is_err());
|
||||
assert!(parse(HorizontalPosition::parse, "x-end").is_err());
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn test_vertical_position() {
|
||||
// One value serializations.
|
||||
assert_roundtrip_with_context!(VerticalPosition::parse, "20px", "20px");
|
||||
assert_roundtrip_with_context!(VerticalPosition::parse, "25%", "25%");
|
||||
assert_roundtrip_with_context!(VerticalPosition::parse, "center", "center");
|
||||
assert_roundtrip_with_context!(VerticalPosition::parse, "top", "top");
|
||||
assert_roundtrip_with_context!(VerticalPosition::parse, "bottom", "bottom");
|
||||
|
||||
// Two value serializations.
|
||||
assert_roundtrip_with_context!(VerticalPosition::parse, "bottom 10px", "bottom 10px");
|
||||
|
||||
// Invalid vertical positions.
|
||||
assert!(parse(VerticalPosition::parse, "left").is_err());
|
||||
assert!(parse(VerticalPosition::parse, "right").is_err());
|
||||
assert!(parse(VerticalPosition::parse, "x-start").is_err());
|
||||
assert!(parse(VerticalPosition::parse, "x-end").is_err());
|
||||
assert!(parse(VerticalPosition::parse, "x-end 20px").is_err());
|
||||
assert!(parse(VerticalPosition::parse, "left 20px").is_err());
|
||||
assert!(parse(VerticalPosition::parse, "left center").is_err());
|
||||
assert!(parse(VerticalPosition::parse, "left top").is_err());
|
||||
assert!(parse(VerticalPosition::parse, "left right").is_err());
|
||||
assert!(parse_entirely(VerticalPosition::parse, "20px x-end").is_err());
|
||||
assert!(parse_entirely(VerticalPosition::parse, "20px right").is_err());
|
||||
assert!(parse_entirely(VerticalPosition::parse, "bottom top").is_err());
|
||||
assert!(parse_entirely(VerticalPosition::parse, "20px 30px").is_err());
|
||||
assert!(parse_entirely(VerticalPosition::parse, "10px top").is_err());
|
||||
assert!(parse_entirely(VerticalPosition::parse, "y-end 20%").is_err());
|
||||
assert!(parse_entirely(VerticalPosition::parse, "20px y-start").is_err());
|
||||
|
||||
// Logical keywords are not supported in Position yet.
|
||||
assert!(parse(VerticalPosition::parse, "y-start").is_err());
|
||||
assert!(parse(VerticalPosition::parse, "y-end").is_err());
|
||||
}
|
||||
Loading…
Add table
Add a link
Reference in a new issue