From 3fa2668afcce16ac4ef045bc08b2a62de98fee2f Mon Sep 17 00:00:00 2001 From: Josh Matthews Date: Thu, 9 May 2019 10:39:16 -0400 Subject: [PATCH 1/2] Use better variable quoting style. --- etc/ci/update-wpt-checkout | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/etc/ci/update-wpt-checkout b/etc/ci/update-wpt-checkout index 2ddcc1d53dd..4b4f60acc26 100755 --- a/etc/ci/update-wpt-checkout +++ b/etc/ci/update-wpt-checkout @@ -92,7 +92,7 @@ function unsafe_open_pull_request() { git checkout "${BRANCH_NAME}" || return 0 if [[ -z "${WPT_SYNC_TOKEN+set}" ]]; then - SECRET_RESPONSE=$(curl $TASKCLUSTER_PROXY_URL/api/secrets/v1/secret/project/servo/wpt-sync) + SECRET_RESPONSE=$(curl ${TASKCLUSTER_PROXY_URL}/secrets/v1/secret/project/servo/wpt-sync) WPT_SYNC_TOKEN=`echo "${SECRET_RESPONSE}" | jq '.secret.token'` fi From 6e99dcd2806c24b3d6eb3e1458231277f2b107ce Mon Sep 17 00:00:00 2001 From: Josh Matthews Date: Thu, 9 May 2019 11:50:33 -0400 Subject: [PATCH 2/2] Don't include JSON string quotes in credentials. --- etc/ci/update-wpt-checkout | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/etc/ci/update-wpt-checkout b/etc/ci/update-wpt-checkout index 4b4f60acc26..c8b3ece372d 100755 --- a/etc/ci/update-wpt-checkout +++ b/etc/ci/update-wpt-checkout @@ -93,7 +93,7 @@ function unsafe_open_pull_request() { if [[ -z "${WPT_SYNC_TOKEN+set}" ]]; then SECRET_RESPONSE=$(curl ${TASKCLUSTER_PROXY_URL}/secrets/v1/secret/project/servo/wpt-sync) - WPT_SYNC_TOKEN=`echo "${SECRET_RESPONSE}" | jq '.secret.token'` + WPT_SYNC_TOKEN=`echo "${SECRET_RESPONSE}" | jq --raw-output '.secret.token'` fi if [[ -z "${WPT_SYNC_TOKEN}" ]]; then