From 5a4e232cb67204042b1c2bf36ccb0237ac84f1ef Mon Sep 17 00:00:00 2001 From: Barigbue Nbira Date: Fri, 28 Mar 2025 12:20:59 +0100 Subject: [PATCH] fix: prevent missing value error for radio button inputs without a name (#36197) Signed-off-by: Barigbue --- components/script/dom/htmlinputelement.rs | 3 +++ .../form-validation-validity-valueMissing.html.ini | 5 ----- 2 files changed, 3 insertions(+), 5 deletions(-) delete mode 100644 tests/wpt/meta/html/semantics/forms/constraints/form-validation-validity-valueMissing.html.ini diff --git a/components/script/dom/htmlinputelement.rs b/components/script/dom/htmlinputelement.rs index d21cf081a95..401abac60ed 100644 --- a/components/script/dom/htmlinputelement.rs +++ b/components/script/dom/htmlinputelement.rs @@ -810,6 +810,9 @@ impl HTMLInputElement { InputType::Checkbox => self.Required() && !self.Checked(), // https://html.spec.whatwg.org/multipage/#radio-button-state-(type%3Dradio)%3Asuffering-from-being-missing InputType::Radio => { + if self.radio_group_name().is_none() { + return false; + } let mut is_required = self.Required(); let mut is_checked = self.Checked(); for other in radio_group_iter(self, self.radio_group_name().as_ref()) { diff --git a/tests/wpt/meta/html/semantics/forms/constraints/form-validation-validity-valueMissing.html.ini b/tests/wpt/meta/html/semantics/forms/constraints/form-validation-validity-valueMissing.html.ini deleted file mode 100644 index af3b0df0e95..00000000000 --- a/tests/wpt/meta/html/semantics/forms/constraints/form-validation-validity-valueMissing.html.ini +++ /dev/null @@ -1,5 +0,0 @@ -[form-validation-validity-valueMissing.html] - type: testharness - [[INPUT in RADIO status\] The checked attribute is false and the name attribute is empty] - expected: FAIL -