From 5a95a30e1473fec7e5e5318be5eb3e4c29ff9025 Mon Sep 17 00:00:00 2001
From: Luis de Bethencourt <luis@debethencourt.com>
Date: Sat, 21 Sep 2013 15:33:12 -0400
Subject: [PATCH] Removing unnecessary constant window title update

update_window_title() is called constantly in the compositor loop. This function
always changes the title to "Servo" when in idle state so it is spamming the X
server with constant changes. But this isn't necessary because updating the
title is taken care of when the Rendering or Ready state are changed in
set_ready_state() and set_render_state().

Fixes #830

Happy Software Freedom Day
---
 .../main/platform/common/glfw_windowing.rs         | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/src/components/main/platform/common/glfw_windowing.rs b/src/components/main/platform/common/glfw_windowing.rs
index ceef183301f..de02a9b861c 100644
--- a/src/components/main/platform/common/glfw_windowing.rs
+++ b/src/components/main/platform/common/glfw_windowing.rs
@@ -136,7 +136,7 @@ impl WindowMethods<Application> for Window {
         }
         glfw::poll_events();
         self.throbber_frame = (self.throbber_frame + 1) % (THROBBER.len() as u8);
-        self.update_window_title();
+        self.update_window_title(false);
         if self.glfw_window.should_close() {
             QuitWindowEvent
         } else if !self.event_queue.is_empty() {
@@ -149,7 +149,7 @@ impl WindowMethods<Application> for Window {
     /// Sets the ready state.
     fn set_ready_state(@mut self, ready_state: ReadyState) {
         self.ready_state = ready_state;
-        self.update_window_title()
+        self.update_window_title(true)
     }
 
     /// Sets the render state.
@@ -162,7 +162,7 @@ impl WindowMethods<Application> for Window {
         }
 
         self.render_state = render_state;
-        self.update_window_title()
+        self.update_window_title(true)
     }
 
     fn hidpi_factor(@mut self) -> f32 {
@@ -174,11 +174,11 @@ impl WindowMethods<Application> for Window {
 
 impl Window {
     /// Helper function to set the window title in accordance with the ready state.
-    fn update_window_title(&self) {
+    fn update_window_title(&self, state_change: bool) {
         let throbber = THROBBER[self.throbber_frame];
         match self.ready_state {
             Blank => {
-                self.glfw_window.set_title(fmt!("blank — Servo"));
+                if state_change { self.glfw_window.set_title(fmt!("blank — Servo")) }
             }
             Loading => {
                 self.glfw_window.set_title(fmt!("%c Loading — Servo", throbber))
@@ -191,7 +191,9 @@ impl Window {
                     RenderingRenderState => {
                         self.glfw_window.set_title(fmt!("%c Rendering — Servo", throbber))
                     }
-                    IdleRenderState => self.glfw_window.set_title("Servo"),
+                    IdleRenderState => {
+                        if state_change { self.glfw_window.set_title("Servo") }
+                    }
                 }
             }
         }