From 5b340599f2a100368aa53c427e8b2d14db9271e9 Mon Sep 17 00:00:00 2001 From: Matthew Rasmus Date: Thu, 22 Jan 2015 12:38:13 -0800 Subject: [PATCH] Fix 'inline-block' sizing issues Fixes #3624 --- components/layout/inline.rs | 13 ++++++++----- tests/ref/basic.list | 2 ++ tests/ref/inline_block_parent_width.html | 17 +++++++++++++++++ .../inline_block_parent_width_percentage.html | 17 +++++++++++++++++ tests/ref/inline_block_parent_width_ref.html | 17 +++++++++++++++++ 5 files changed, 61 insertions(+), 5 deletions(-) create mode 100644 tests/ref/inline_block_parent_width.html create mode 100644 tests/ref/inline_block_parent_width_percentage.html create mode 100644 tests/ref/inline_block_parent_width_ref.html diff --git a/components/layout/inline.rs b/components/layout/inline.rs index c1a518dbfe9..722acc51d15 100644 --- a/components/layout/inline.rs +++ b/components/layout/inline.rs @@ -1117,10 +1117,10 @@ impl Flow for InlineFlow { debug!("InlineFlow::assign_inline_sizes: floats in: {:?}", self.base.floats); - self.base.position.size.inline = self.base.block_container_inline_size; + let inline_size = self.base.block_container_inline_size; + self.base.position.size.inline = inline_size; { - let inline_size = self.base.position.size.inline; let this = &mut *self; for fragment in this.fragments.fragments.iter_mut() { fragment.compute_border_and_padding(inline_size); @@ -1130,11 +1130,14 @@ impl Flow for InlineFlow { } } - // If there are any inline-block kids, propagate explicit block sizes down to them. + // If there are any inline-block kids, propagate explicit block and inline + // sizes down to them. let block_container_explicit_block_size = self.base.block_container_explicit_block_size; for kid in self.base.child_iter() { - flow::mut_base(kid).block_container_explicit_block_size = - block_container_explicit_block_size; + let kid_base = flow::mut_base(kid); + + kid_base.block_container_inline_size = inline_size; + kid_base.block_container_explicit_block_size = block_container_explicit_block_size; } } diff --git a/tests/ref/basic.list b/tests/ref/basic.list index 96c01f4b87e..a733a543904 100644 --- a/tests/ref/basic.list +++ b/tests/ref/basic.list @@ -141,6 +141,8 @@ fragment=top != ../html/acid2.html acid2_ref.html == inline_block_margin_a.html inline_block_margin_ref.html == inline_block_img_a.html inline_block_img_ref.html == inline_block_baseline_a.html inline_block_baseline_ref.html +== inline_block_parent_width.html inline_block_parent_width_ref.html +== inline_block_parent_width_percentage.html inline_block_parent_width_ref.html == float_table_a.html float_table_ref.html == table_containing_block_a.html table_containing_block_ref.html == link_style_order.html link_style_order_ref.html diff --git a/tests/ref/inline_block_parent_width.html b/tests/ref/inline_block_parent_width.html new file mode 100644 index 00000000000..520339a5a51 --- /dev/null +++ b/tests/ref/inline_block_parent_width.html @@ -0,0 +1,17 @@ + + + +
+
+ Bloobity bloobity bloobity bloobity + bloobity bloobity bloobity bloobity + bloobity bloobity bloobity bloobity + bloobity bloobity bloobity bloobity + bloobity bloobity bloobity bloobity + bloobity bloobity bloobity bloobity + bloobity bloobity bloobity bloobity + bloobity bloobity bloobity bloobity +
+
+ + diff --git a/tests/ref/inline_block_parent_width_percentage.html b/tests/ref/inline_block_parent_width_percentage.html new file mode 100644 index 00000000000..ed6bcf1ee89 --- /dev/null +++ b/tests/ref/inline_block_parent_width_percentage.html @@ -0,0 +1,17 @@ + + + +
+
+ Bloobity bloobity bloobity bloobity + bloobity bloobity bloobity bloobity + bloobity bloobity bloobity bloobity + bloobity bloobity bloobity bloobity + bloobity bloobity bloobity bloobity + bloobity bloobity bloobity bloobity + bloobity bloobity bloobity bloobity + bloobity bloobity bloobity bloobity +
+
+ + diff --git a/tests/ref/inline_block_parent_width_ref.html b/tests/ref/inline_block_parent_width_ref.html new file mode 100644 index 00000000000..d9d9fff3b90 --- /dev/null +++ b/tests/ref/inline_block_parent_width_ref.html @@ -0,0 +1,17 @@ + + + +
+
+ Bloobity bloobity bloobity bloobity + bloobity bloobity bloobity bloobity + bloobity bloobity bloobity bloobity + bloobity bloobity bloobity bloobity + bloobity bloobity bloobity bloobity + bloobity bloobity bloobity bloobity + bloobity bloobity bloobity bloobity + bloobity bloobity bloobity bloobity +
+
+ +