Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-24 06:45:33 +01:00
Code Issues Projects Releases Packages Wiki Activity

style: Remove ThinBoxedSlice

Browse source 
The only remaining consumers are ::-moz-tree pseudo-elements (we used to
use ThinBoxedSlice for other data structures in the past).

Those are not particularly performance sensitive so I think just
double-boxing is fine. In the future, if we wanted to avoid the double
indirection, we could probably use the "thin" crate
(https://docs.rs/thin) or similar, which stores the length of the slice
along with the allocation, making the pointer thin in all
configurations, much like "ThinArc" does:

  https://searchfox.org/mozilla-central/rev/1ce2eea39442190a71a1f8f650d098f286bf4a01/servo/components/servo_arc/lib.rs#891

In practice though, I don't think it's particularly worth it for this
specific case.

Differential Revision: https://phabricator.services.mozilla.com/D134672
This commit is contained in:
Emilio Cobos Álvarez 2023-06-06 23:25:18 +02:00 • committed by Oriol Brufau
parent fc4d185079
commit 5b62f66f6e
7 changed files with 5 additions and 43 deletions
Download patch file Download diff file Expand all files Collapse all files

1
components/malloc_size_of/Cargo.toml
View file

@ -44,7 +44,6 @@ servo_arc = { path = "../servo_arc" }
smallbitvec = { workspace = true }
smallvec = { workspace = true }
string_cache = { workspace = true, optional = true }
thin-slice = { workspace = true }
time = { workspace = true, optional = true }
tokio = { workspace = true }
url = { workspace = true, optional = true }