Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-09-03 03:28:20 +01:00
Code Issues Projects Releases Packages Wiki Activity

style: Remove ThinBoxedSlice

Browse source 
The only remaining consumers are ::-moz-tree pseudo-elements (we used to
use ThinBoxedSlice for other data structures in the past).

Those are not particularly performance sensitive so I think just
double-boxing is fine. In the future, if we wanted to avoid the double
indirection, we could probably use the "thin" crate
(https://docs.rs/thin) or similar, which stores the length of the slice
along with the allocation, making the pointer thin in all
configurations, much like "ThinArc" does:

  https://searchfox.org/mozilla-central/rev/1ce2eea39442190a71a1f8f650d098f286bf4a01/servo/components/servo_arc/lib.rs#891

In practice though, I don't think it's particularly worth it for this
specific case.

Differential Revision: https://phabricator.services.mozilla.com/D134672
This commit is contained in:
Emilio Cobos Álvarez 2023-06-06 23:25:18 +02:00 • committed by Oriol Brufau
parent fc4d185079
commit 5b62f66f6e
7 changed files with 5 additions and 43 deletions
Download patch file Download diff file Expand all files Collapse all files

4
components/style/Cargo.toml
View file

@ -17,8 +17,7 @@ path = "lib.rs"
doctest = false
[features]
gecko = ["style_traits/gecko", "bindgen", "regex", "toml",
"num_cpus", "thin-slice"]
gecko = ["style_traits/gecko", "bindgen", "regex", "toml", "num_cpus"]
servo = ["serde", "style_traits/servo", "servo_atoms", "servo_config", "html5ever",
"cssparser/serde", "encoding_rs", "malloc_size_of/servo", "servo_url",
"string_cache", "to_shmem/servo",
@ -68,7 +67,6 @@ smallvec = "1.0"
string_cache = { version = "0.8", optional = true }
style_derive = { path = "../style_derive" }
style_traits = { path = "../style_traits" }
thin-slice = { version = "0.1.0", optional = true }
time = "0.1"
to_shmem = { path = "../to_shmem" }
to_shmem_derive = { path = "../to_shmem_derive" }