Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-06 06:00:15 +01:00
Code Issues Projects Releases Packages Wiki Activity

layout: Fix calculation of overflow for stacking contexts that contain

Browse source 
`position: relative` fragments.

Fixes placement of the header on espn.go.com.
This commit is contained in:
Patrick Walton 2015-08-25 15:04:03 -07:00
parent f79220f1a8
commit 5c51a6214e
8 changed files with 27 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

10
components/layout/display_list_builder.rs
View file

@ -1148,9 +1148,6 @@ impl FragmentDisplayListBuilding for Fragment {
layer: StackingContextLayer,
mode: StackingContextCreationMode)
-> Arc<StackingContext> {
// FIXME(pcwalton): Is this vertical-writing-direction-safe?
let margin = self.margin.to_physical(base_flow.writing_mode);
let border_box = match mode {
StackingContextCreationMode::Normal |
StackingContextCreationMode::OuterScrollWrapper => {
@ -1167,7 +1164,12 @@ impl FragmentDisplayListBuilding for Fragment {
};
let overflow = match mode {
StackingContextCreationMode::Normal => {
base_flow.overflow.translate(&-Point2D::new(margin.left, Au(0)))
// First, compute the offset of our border box (including relative positioning)
// from our flow origin, since that is what `BaseFlow::overflow` is relative to.
let border_box_offset =
border_box.translate(&-base_flow.stacking_relative_position).origin;
// Then, using that, compute our overflow region relative to our border box.
base_flow.overflow.translate(&-border_box_offset)
}
StackingContextCreationMode::InnerScrollWrapper |
StackingContextCreationMode::OuterScrollWrapper => {