diff --git a/components/script/dom/bindings/codegen/CodegenRust.py b/components/script/dom/bindings/codegen/CodegenRust.py index 795204466df..6fa1b75fcd4 100644 --- a/components/script/dom/bindings/codegen/CodegenRust.py +++ b/components/script/dom/bindings/codegen/CodegenRust.py @@ -3016,7 +3016,7 @@ class CGUnionConversionStruct(CGThing): post="\n}") return CGWrapper( CGIndenter(method), - pre="impl FromJSValConvertible<()> for %s {\n" % self.type, + pre="impl FromJSValConvertible for %s {\ntype Config = ();\n" % self.type, post="\n}") def try_method(self, t): diff --git a/components/script/dom/bindings/conversions.rs b/components/script/dom/bindings/conversions.rs index bf805a35fbf..d7182f8993f 100644 --- a/components/script/dom/bindings/conversions.rs +++ b/components/script/dom/bindings/conversions.rs @@ -49,12 +49,13 @@ pub trait ToJSValConvertible { } /// A trait to convert `JSVal`s to Rust types. -pub trait FromJSValConvertible { +pub trait FromJSValConvertible { + type Config; /// Convert `val` to type `Self`. /// Optional configuration of type `T` can be passed as the `option` /// argument. /// If it returns `Err(())`, a JSAPI exception is pending. - fn from_jsval(cx: *mut JSContext, val: JSVal, option: T) -> Result; + fn from_jsval(cx: *mut JSContext, val: JSVal, option: Self::Config) -> Result; } @@ -92,7 +93,8 @@ impl ToJSValConvertible for bool { } } -impl FromJSValConvertible<()> for bool { +impl FromJSValConvertible for bool { + type Config = (); fn from_jsval(cx: *mut JSContext, val: JSVal, _option: ()) -> Result { let result = unsafe { convert_from_jsval(cx, val, JS_ValueToBoolean) }; result.map(|b| b != 0) @@ -105,7 +107,8 @@ impl ToJSValConvertible for i8 { } } -impl FromJSValConvertible<()> for i8 { +impl FromJSValConvertible for i8 { + type Config = (); fn from_jsval(cx: *mut JSContext, val: JSVal, _option: ()) -> Result { let result = unsafe { convert_from_jsval(cx, val, JS_ValueToECMAInt32) }; result.map(|v| v as i8) @@ -118,7 +121,8 @@ impl ToJSValConvertible for u8 { } } -impl FromJSValConvertible<()> for u8 { +impl FromJSValConvertible for u8 { + type Config = (); fn from_jsval(cx: *mut JSContext, val: JSVal, _option: ()) -> Result { let result = unsafe { convert_from_jsval(cx, val, JS_ValueToECMAInt32) }; result.map(|v| v as u8) @@ -131,7 +135,8 @@ impl ToJSValConvertible for i16 { } } -impl FromJSValConvertible<()> for i16 { +impl FromJSValConvertible for i16 { + type Config = (); fn from_jsval(cx: *mut JSContext, val: JSVal, _option: ()) -> Result { let result = unsafe { convert_from_jsval(cx, val, JS_ValueToECMAInt32) }; result.map(|v| v as i16) @@ -144,7 +149,8 @@ impl ToJSValConvertible for u16 { } } -impl FromJSValConvertible<()> for u16 { +impl FromJSValConvertible for u16 { + type Config = (); fn from_jsval(cx: *mut JSContext, val: JSVal, _option: ()) -> Result { unsafe { convert_from_jsval(cx, val, JS_ValueToUint16) } } @@ -156,7 +162,8 @@ impl ToJSValConvertible for i32 { } } -impl FromJSValConvertible<()> for i32 { +impl FromJSValConvertible for i32 { + type Config = (); fn from_jsval(cx: *mut JSContext, val: JSVal, _option: ()) -> Result { unsafe { convert_from_jsval(cx, val, JS_ValueToECMAInt32) } } @@ -168,7 +175,8 @@ impl ToJSValConvertible for u32 { } } -impl FromJSValConvertible<()> for u32 { +impl FromJSValConvertible for u32 { + type Config = (); fn from_jsval(cx: *mut JSContext, val: JSVal, _option: ()) -> Result { unsafe { convert_from_jsval(cx, val, JS_ValueToECMAUint32) } } @@ -182,7 +190,8 @@ impl ToJSValConvertible for i64 { } } -impl FromJSValConvertible<()> for i64 { +impl FromJSValConvertible for i64 { + type Config = (); fn from_jsval(cx: *mut JSContext, val: JSVal, _option: ()) -> Result { unsafe { convert_from_jsval(cx, val, JS_ValueToInt64) } } @@ -196,7 +205,8 @@ impl ToJSValConvertible for u64 { } } -impl FromJSValConvertible<()> for u64 { +impl FromJSValConvertible for u64 { + type Config = (); fn from_jsval(cx: *mut JSContext, val: JSVal, _option: ()) -> Result { unsafe { convert_from_jsval(cx, val, JS_ValueToUint64) } } @@ -210,7 +220,8 @@ impl ToJSValConvertible for f32 { } } -impl FromJSValConvertible<()> for f32 { +impl FromJSValConvertible for f32 { + type Config = (); fn from_jsval(cx: *mut JSContext, val: JSVal, _option: ()) -> Result { let result = unsafe { convert_from_jsval(cx, val, JS_ValueToNumber) }; result.map(|f| f as f32) @@ -225,7 +236,8 @@ impl ToJSValConvertible for f64 { } } -impl FromJSValConvertible<()> for f64 { +impl FromJSValConvertible for f64 { + type Config = (); fn from_jsval(cx: *mut JSContext, val: JSVal, _option: ()) -> Result { unsafe { convert_from_jsval(cx, val, JS_ValueToNumber) } } @@ -285,7 +297,8 @@ pub fn jsid_to_str(cx: *mut JSContext, id: jsid) -> DOMString { } } -impl FromJSValConvertible for DOMString { +impl FromJSValConvertible for DOMString { + type Config = StringificationBehavior; fn from_jsval(cx: *mut JSContext, value: JSVal, null_behavior: StringificationBehavior) -> Result { @@ -317,7 +330,8 @@ impl ToJSValConvertible for ByteString { } } -impl FromJSValConvertible<()> for ByteString { +impl FromJSValConvertible for ByteString { + type Config = (); fn from_jsval(cx: *mut JSContext, value: JSVal, _option: ()) -> Result { unsafe { let string = JS_ValueToString(cx, value); @@ -462,7 +476,8 @@ pub fn unwrap_jsmanaged(mut obj: *mut JSObject) -> Result, ()> } } -impl FromJSValConvertible<()> for JS { +impl FromJSValConvertible for JS { + type Config = (); fn from_jsval(_cx: *mut JSContext, value: JSVal, _option: ()) -> Result, ()> { if !value.is_object() { return Err(()); @@ -498,8 +513,8 @@ impl ToJSValConvertible for Option { } } -#[old_impl_check] -impl> FromJSValConvertible<()> for Option { +impl> FromJSValConvertible for Option { + type Config = (); fn from_jsval(cx: *mut JSContext, value: JSVal, _: ()) -> Result, ()> { if value.is_null_or_undefined() { Ok(None) diff --git a/components/script/lib.rs b/components/script/lib.rs index 5ffaa96b657..fdc69fd73f9 100644 --- a/components/script/lib.rs +++ b/components/script/lib.rs @@ -3,7 +3,6 @@ * file, You can obtain one at http://mozilla.org/MPL/2.0/. */ #![feature(unsafe_destructor, plugin, box_syntax, int_uint)] -#![feature(old_impl_check)] #![deny(unsafe_blocks)] #![deny(unused_imports)]