mirror of
https://github.com/servo/servo.git
synced 2025-08-07 06:25:32 +01:00
script: Add generic root storage to StructuredCloneReader. (#36640)
This reduces the boilerplate necessary for adding new serializable/transferable interfaces to the structured cloning code. We always need to root the deserialized objects when performing a read operation, but we don't actually need the concrete object types in the majority of cases. By storing a list of rooted JS object values, we can push generic reflector objects into it, and extract the types we need (MessagePort) at the very end. Testing: Existing WPT structured cloning tests will provide coverage. Signed-off-by: Josh Matthews <josh@joshmatthews.net>
This commit is contained in:
parent
7c1e5918a8
commit
5d3cbc67ee
10 changed files with 73 additions and 126 deletions
|
@ -23,7 +23,7 @@ use crate::dom::bindings::error::{Error, ErrorResult, ErrorToJsval};
|
|||
use crate::dom::bindings::inheritance::Castable;
|
||||
use crate::dom::bindings::reflector::{DomGlobal, reflect_dom_object};
|
||||
use crate::dom::bindings::root::DomRoot;
|
||||
use crate::dom::bindings::structuredclone::{self, StructuredData, StructuredDataReader};
|
||||
use crate::dom::bindings::structuredclone::{self, StructuredData};
|
||||
use crate::dom::bindings::trace::RootedTraceableBox;
|
||||
use crate::dom::bindings::transferable::Transferable;
|
||||
use crate::dom::bindings::utils::set_dictionary_property;
|
||||
|
@ -268,18 +268,14 @@ impl Transferable for MessagePort {
|
|||
Ok(transferred_port)
|
||||
}
|
||||
|
||||
fn serialized_storage(
|
||||
data: StructuredData<'_>,
|
||||
) -> &mut Option<HashMap<MessagePortId, Self::Data>> {
|
||||
fn serialized_storage<'a>(
|
||||
data: StructuredData<'a, '_>,
|
||||
) -> &'a mut Option<HashMap<MessagePortId, Self::Data>> {
|
||||
match data {
|
||||
StructuredData::Reader(r) => &mut r.port_impls,
|
||||
StructuredData::Writer(w) => &mut w.ports,
|
||||
}
|
||||
}
|
||||
|
||||
fn deserialized_storage(reader: &mut StructuredDataReader) -> &mut Option<Vec<DomRoot<Self>>> {
|
||||
&mut reader.message_ports
|
||||
}
|
||||
}
|
||||
|
||||
impl MessagePortMethods<crate::DomTypeHolder> for MessagePort {
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue