Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-03 20:50:07 +01:00
Code Issues Projects Releases Packages Wiki Activity

style: paint-order parsing has off-by-one error.

Browse source 
A couple of firefox only WPT failure caused by this off-by-one bug.

Differential Revision: https://phabricator.services.mozilla.com/D35630
This commit is contained in:
violet 2019-06-24 04:07:42 +00:00 • committed by Emilio Cobos Álvarez
parent 2fba62aba9
commit 5db88db8fc
No known key found for this signature in database
GPG key ID: E1152D0994E4BF8A
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
components/style/values/specified/svg.rs
View file

@ -200,7 +200,7 @@ impl Parse for SVGPaintOrder {
// fill in rest // fill in rest
for i in pos..PAINT_ORDER_COUNT { for i in pos..PAINT_ORDER_COUNT {
for paint in 0..PAINT_ORDER_COUNT { for paint in 1..(PAINT_ORDER_COUNT + 1) {
// if not seen, set bit at position, mark as seen // if not seen, set bit at position, mark as seen
if (seen & (1 << paint)) == 0 { if (seen & (1 << paint)) == 0 {
seen |= 1 << paint; seen |= 1 << paint;