mirror of
https://github.com/servo/servo.git
synced 2025-08-03 04:30:10 +01:00
Include WebViewId
into EmbedderMsg variants where possible (#35211)
`EmbedderMsg` was previously paired with an implicit `Option<WebViewId>`, even though almost all variants were either always `Some` or always `None`, depending on whether there was a `WebView involved. This patch adds the `WebViewId` to as many `EmbedderMsg` variants as possible, so we can call their associated `WebView` delegate methods without needing to check and unwrap the `Option`. In many cases, this required more changes to plumb through the `WebViewId`. Notably, all `Request`s now explicitly need a `WebView` or not, in order to ensure that it is passed when appropriate. Signed-off-by: Delan Azabani <dazabani@igalia.com> Co-authored-by: Martin Robinson <mrobinson@igalia.com>
This commit is contained in:
parent
9eeb602f7a
commit
5e9de2cb61
70 changed files with 809 additions and 753 deletions
|
@ -7,8 +7,7 @@
|
|||
//!
|
||||
//! <https://html.spec.whatwg.org/multipage/#textFieldSelection>
|
||||
|
||||
use script_traits::ScriptToConstellationChan;
|
||||
|
||||
use crate::clipboard_provider::EmbedderClipboardProvider;
|
||||
use crate::dom::bindings::cell::DomRefCell;
|
||||
use crate::dom::bindings::codegen::Bindings::HTMLFormElementBinding::SelectionMode;
|
||||
use crate::dom::bindings::conversions::DerivedFrom;
|
||||
|
@ -27,13 +26,13 @@ pub(crate) trait TextControlElement: DerivedFrom<EventTarget> + DerivedFrom<Node
|
|||
|
||||
pub(crate) struct TextControlSelection<'a, E: TextControlElement> {
|
||||
element: &'a E,
|
||||
textinput: &'a DomRefCell<TextInput<ScriptToConstellationChan>>,
|
||||
textinput: &'a DomRefCell<TextInput<EmbedderClipboardProvider>>,
|
||||
}
|
||||
|
||||
impl<'a, E: TextControlElement> TextControlSelection<'a, E> {
|
||||
pub(crate) fn new(
|
||||
element: &'a E,
|
||||
textinput: &'a DomRefCell<TextInput<ScriptToConstellationChan>>,
|
||||
textinput: &'a DomRefCell<TextInput<EmbedderClipboardProvider>>,
|
||||
) -> Self {
|
||||
TextControlSelection { element, textinput }
|
||||
}
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue