Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-06 22:15:33 +01:00
Code Issues Projects Releases Packages Wiki Activity

Fix write_json_to_file perf regressions (#37687)

Browse source 
cd30b78 improved the memory efficiency of write_json_to_file, but this
causes visible (when profiling) perf regression on my mac, which can
easily be fixed by wrapping the file in a `BufWriter`. This still bounds
peak memory usage, but keeps writing efficient.

Testing: Manual profiling with samply.

Signed-off-by: Jonathan Schwender <schwenderjonathan@gmail.com>
This commit is contained in:
Jonathan Schwender 2025-06-25 10:45:20 +02:00 • committed by GitHub
parent 4ee348a202
commit 5ea003752a
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
components/net/resource_thread.rs
View file

@ -8,7 +8,7 @@ use std::borrow::ToOwned;
use std::collections::HashMap; use std::collections::HashMap;
use std::fs::File; use std::fs::File;
use std::io::prelude::*; use std::io::prelude::*;
use std::io::{self, BufReader}; use std::io::{self, BufReader, BufWriter};
use std::path::{Path, PathBuf}; use std::path::{Path, PathBuf};
use std::sync::{Arc, Mutex, RwLock, Weak}; use std::sync::{Arc, Mutex, RwLock, Weak};
use std::thread; use std::thread;
@ -524,8 +524,8 @@ where
Err(why) => panic!("couldn't create {}: {}", display, why), Err(why) => panic!("couldn't create {}: {}", display, why),
Ok(file) => file, Ok(file) => file,
}; };
let mut writer = BufWriter::new(&mut file);
serde_json::to_writer_pretty(&mut file, data).expect("Could not serialize to file"); serde_json::to_writer_pretty(&mut writer, data).expect("Could not serialize to file");
trace!("successfully wrote to {display}"); trace!("successfully wrote to {display}");
} }