From 5f2d512c12b6158af22502cb09f3543ff015d864 Mon Sep 17 00:00:00 2001 From: Eric Anholt Date: Sat, 5 May 2018 18:25:20 -0700 Subject: [PATCH] webgl: Drop a silly check for 0 in GetTexParameter. 0 is not among the valid values for a wrap mode or filter, so it won't ever be returned unless the driver is broken, and even if it was a valid value we would want to pass it through. --- components/script/dom/webglrenderingcontext.rs | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/components/script/dom/webglrenderingcontext.rs b/components/script/dom/webglrenderingcontext.rs index d1383cded5d..17c63a78d48 100644 --- a/components/script/dom/webglrenderingcontext.rs +++ b/components/script/dom/webglrenderingcontext.rs @@ -1412,13 +1412,7 @@ impl WebGLRenderingContextMethods for WebGLRenderingContext { let (sender, receiver) = webgl_channel().unwrap(); self.send_command(WebGLCommand::GetTexParameter(target, pname, sender)); - match receiver.recv().unwrap() { - value if value != 0 => Int32Value(value), - _ => { - self.webgl_error(InvalidEnum); - NullValue() - } - } + Int32Value(receiver.recv().unwrap()) } // https://www.khronos.org/registry/webgl/specs/latest/1.0/#5.14.3