From 5f5ea8603df3fd5dadbfcaaee2619a311af77b7c Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Emilio=20Cobos=20=C3=81lvarez?= Date: Tue, 23 May 2023 20:49:05 +0200 Subject: [PATCH] style: Fix selecteditem color on macOS This is an oversight. I made selecteditem be -moz-html-cellhighlight, but that's for inactive cells. Use the inactive cell color everywhere (though android doesn't differentiate). This matches other browsers and what was reviewed on this bug. MANUAL PUSH: The semi-transparent text-selection-disabled color caused one test failure CLOSED TREE. --- components/style/values/specified/color.rs | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/components/style/values/specified/color.rs b/components/style/values/specified/color.rs index 371d69450b4..332a5617805 100644 --- a/components/style/values/specified/color.rs +++ b/components/style/values/specified/color.rs @@ -347,14 +347,14 @@ pub enum SystemColor { /// Used to highlight valid regions to drop something onto. MozDragtargetzone, /// Used for selected but not focused cell backgrounds. + #[parse(aliases = "-moz-html-cellhighlight")] MozCellhighlight, /// Used for selected but not focused cell text. - MozCellhighlighttext, - /// Used for selected but not focused html cell backgrounds. - #[parse(aliases = "-moz-html-cellhighlight")] - Selecteditem, - /// Used for selected but not focused html cell text. #[parse(aliases = "-moz-html-cellhighlighttext")] + MozCellhighlighttext, + /// Used for selected and focused html cell backgrounds. + Selecteditem, + /// Used for selected and focused html cell text. Selecteditemtext, /// Used to button text background when hovered. MozButtonhoverface,