Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-04 13:10:20 +01:00
Code Issues Projects Releases Packages Wiki Activity

dom: Abort media element load on decode errors (#31748)

Browse source 
Signed-off-by: Frederik Reiter <hi@frereit.de>
This commit is contained in:
Frederik Reiter 2024-03-26 20:05:37 +01:00 • committed by GitHub
parent 4da9d39cca
commit 5f7baf31c2
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 18 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

18
components/script/dom/htmlmediaelement.rs
View file

@ -1549,11 +1549,29 @@ impl HTMLMediaElement {
}, },
PlayerEvent::Error(ref error) => { PlayerEvent::Error(ref error) => {
error!("Player error: {:?}", error); error!("Player error: {:?}", error);
// https://html.spec.whatwg.org/multipage/#loading-the-media-resource:media-data-13
// 1. The user agent should cancel the fetching process.
if let Some(ref mut current_fetch_context) =
*self.current_fetch_context.borrow_mut()
{
current_fetch_context.cancel(CancelReason::Error);
}
// 2. Set the error attribute to the result of creating a MediaError with MEDIA_ERR_DECODE.
self.error.set(Some(&*MediaError::new( self.error.set(Some(&*MediaError::new(
&window_from_node(self), &window_from_node(self),
MEDIA_ERR_DECODE, MEDIA_ERR_DECODE,
))); )));
// 3. Set the element's networkState attribute to the NETWORK_IDLE value.
self.network_state.set(NetworkState::Idle);
// 4. Set the element's delaying-the-load-event flag to false. This stops delaying the load event.
self.delay_load_event(false);
// 5. Fire an event named error at the media element.
self.upcast::<EventTarget>().fire_event(atom!("error")); self.upcast::<EventTarget>().fire_event(atom!("error"));
// TODO: 6. Abort the overall resource selection algorithm.
}, },
PlayerEvent::VideoFrameUpdated => { PlayerEvent::VideoFrameUpdated => {
self.upcast::<Node>().dirty(NodeDamage::OtherNodeDamage); self.upcast::<Node>().dirty(NodeDamage::OtherNodeDamage);