mirror of
https://github.com/servo/servo.git
synced 2025-08-03 20:50:07 +01:00
Auto merge of #23983 - paulrouget:handlePanic, r=jdm
[hololens] Handle servo panic Depends on #23981 Fix #23937 I've used a different approach than checking the return code of every single functions. Basically calling a C function on panic. That means the errors are not recoverable. I think it's fine for now. I'm open to any other better approach. @jdm what do you think? <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23983) <!-- Reviewable:end -->
This commit is contained in:
commit
5f89dc87bd
4 changed files with 136 additions and 94 deletions
|
@ -22,12 +22,16 @@ void flush() { sServo->Delegate().Flush(); }
|
|||
void make_current() { sServo->Delegate().MakeCurrent(); }
|
||||
void wakeup() { sServo->Delegate().WakeUp(); }
|
||||
bool on_allow_navigation(const char *url) {
|
||||
return sServo->Delegate().OnServoAllowNavigation(char2hstring(url));
|
||||
return sServo->Delegate().OnServoAllowNavigation(char2hstring(url));
|
||||
};
|
||||
void on_animating_changed(bool aAnimating) {
|
||||
sServo->Delegate().OnServoAnimatingChanged(aAnimating);
|
||||
}
|
||||
|
||||
void on_panic(const char *backtrace) {
|
||||
throw hresult_error(E_FAIL, char2hstring(backtrace));
|
||||
}
|
||||
|
||||
Servo::Servo(GLsizei width, GLsizei height, ServoDelegate &aDelegate)
|
||||
: mWindowHeight(height), mWindowWidth(width), mDelegate(aDelegate) {
|
||||
|
||||
|
@ -55,7 +59,9 @@ Servo::Servo(GLsizei width, GLsizei height, ServoDelegate &aDelegate)
|
|||
c.on_shutdown_complete = &on_shutdown_complete;
|
||||
c.on_allow_navigation = &on_allow_navigation;
|
||||
|
||||
init_with_egl(o, &wakeup, c);
|
||||
capi::register_panic_handler(&on_panic);
|
||||
|
||||
capi::init_with_egl(o, &wakeup, c);
|
||||
}
|
||||
|
||||
Servo::~Servo() { sServo = nullptr; }
|
||||
|
@ -63,11 +69,13 @@ Servo::~Servo() { sServo = nullptr; }
|
|||
winrt::hstring char2hstring(const char *c_str) {
|
||||
// FIXME: any better way of doing this?
|
||||
auto str = std::string(c_str);
|
||||
int size_needed = MultiByteToWideChar(CP_UTF8, 0, &str[0], (int)str.size(), NULL, 0);
|
||||
int size_needed =
|
||||
MultiByteToWideChar(CP_UTF8, 0, &str[0], (int)str.size(), NULL, 0);
|
||||
std::wstring str2(size_needed, 0);
|
||||
MultiByteToWideChar(CP_UTF8, 0, &str[0], (int)str.size(), &str2[0], size_needed);
|
||||
winrt::hstring str3 {str2};
|
||||
MultiByteToWideChar(CP_UTF8, 0, &str[0], (int)str.size(), &str2[0],
|
||||
size_needed);
|
||||
winrt::hstring str3{str2};
|
||||
return str3;
|
||||
}
|
||||
|
||||
} // namespace servo
|
||||
} // namespace winrt::servo
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue