From 5fe148d5f1de1284743cb2238a9bca3d1a127282 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Emilio=20Cobos=20=C3=81lvarez?= Date: Sat, 27 May 2023 07:20:11 +0200 Subject: [PATCH] style: Add some parsing and serialization tests for @layer This uncovers some serialization bugs, and some missing null-checks given the statement layer doesn't have a rule list. Differential Revision: https://phabricator.services.mozilla.com/D125176 --- components/style/stylesheets/layer_rule.rs | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/components/style/stylesheets/layer_rule.rs b/components/style/stylesheets/layer_rule.rs index a012c9c5474..c246d5e1b0f 100644 --- a/components/style/stylesheets/layer_rule.rs +++ b/components/style/stylesheets/layer_rule.rs @@ -234,7 +234,7 @@ impl ToCssWithGuard for LayerRule { guard: &SharedRwLockReadGuard, dest: &mut crate::str::CssStringWriter, ) -> fmt::Result { - dest.write_str("@layer ")?; + dest.write_str("@layer")?; match self.kind { LayerRuleKind::Block { ref name, @@ -242,8 +242,8 @@ impl ToCssWithGuard for LayerRule { ref is_anonymous, } => { if !*is_anonymous { - name.to_css(&mut CssWriter::new(dest))?; dest.write_char(' ')?; + name.to_css(&mut CssWriter::new(dest))?; } rules.read_with(guard).to_css_block(guard, dest) }, @@ -251,7 +251,9 @@ impl ToCssWithGuard for LayerRule { let mut writer = CssWriter::new(dest); let mut first = true; for name in &**names { - if !first { + if first { + writer.write_char(' ')?; + } else { writer.write_str(", ")?; } first = false;