From 5ff62b61aa76532b09d1983d492aafdd93f05f18 Mon Sep 17 00:00:00 2001 From: gterzian <2792687+gterzian@users.noreply.github.com> Date: Fri, 23 May 2025 17:41:21 +0800 Subject: [PATCH] remove abort signal and controller interfaces, updates test expectations Signed-off-by: gterzian <2792687+gterzian@users.noreply.github.com> --- .../webidls/AbortSignal.webidl | 2 +- tests/wpt/meta/dom/idlharness.any.js.ini | 30 +++++++++++++++++++ tests/wpt/meta/dom/interface-objects.html.ini | 3 ++ .../wpt/meta/streams/piping/abort.any.js.ini | 2 ++ .../streams/piping/pipe-through.any.js.ini | 17 +++++------ tests/wpt/mozilla/meta/MANIFEST.json | 4 +-- .../tests/mozilla/interfaces.https.html | 2 -- .../tests/mozilla/interfaces.worker.js | 2 -- 8 files changed, 46 insertions(+), 16 deletions(-) diff --git a/components/script_bindings/webidls/AbortSignal.webidl b/components/script_bindings/webidls/AbortSignal.webidl index bea70e41739..1ec9fbcd3a4 100644 --- a/components/script_bindings/webidls/AbortSignal.webidl +++ b/components/script_bindings/webidls/AbortSignal.webidl @@ -4,7 +4,7 @@ // https://dom.spec.whatwg.org/#abortsignal -[Exposed=*] +[Exposed=*, Pref="dom_abort_controller_enabled"] interface AbortSignal : EventTarget { readonly attribute boolean aborted; readonly attribute any reason; diff --git a/tests/wpt/meta/dom/idlharness.any.js.ini b/tests/wpt/meta/dom/idlharness.any.js.ini index b494428e3f4..c75d2d801bf 100644 --- a/tests/wpt/meta/dom/idlharness.any.js.ini +++ b/tests/wpt/meta/dom/idlharness.any.js.ini @@ -17,9 +17,33 @@ [AbortController interface: new AbortController() must inherit property "abort()" with the proper type] expected: FAIL + [AbortSignal interface: existence and properties of interface object] + expected: FAIL + + [AbortSignal interface object length] + expected: FAIL + + [AbortSignal interface object name] + expected: FAIL + + [AbortSignal interface: existence and properties of interface prototype object] + expected: FAIL + + [AbortSignal interface: existence and properties of interface prototype object's "constructor" property] + expected: FAIL + + [AbortSignal interface: existence and properties of interface prototype object's @@unscopables property] + expected: FAIL + [AbortSignal interface: operation abort()] expected: FAIL + [AbortSignal interface: attribute aborted] + expected: FAIL + + [AbortSignal interface: attribute onabort] + expected: FAIL + [AbortSignal must be primary interface of new AbortController().signal] expected: FAIL @@ -56,6 +80,12 @@ [AbortSignal interface: operation abort(optional any)] expected: FAIL + [AbortSignal interface: attribute reason] + expected: FAIL + + [AbortSignal interface: operation throwIfAborted()] + expected: FAIL + [AbortSignal interface: new AbortController().signal must inherit property "abort(optional any)" with the proper type] expected: FAIL diff --git a/tests/wpt/meta/dom/interface-objects.html.ini b/tests/wpt/meta/dom/interface-objects.html.ini index 9b08fb2e7ce..ddc761b4169 100644 --- a/tests/wpt/meta/dom/interface-objects.html.ini +++ b/tests/wpt/meta/dom/interface-objects.html.ini @@ -1,3 +1,6 @@ [interface-objects.html] + [Should be able to delete AbortSignal.] + expected: FAIL + [Should be able to delete AbortController.] expected: FAIL diff --git a/tests/wpt/meta/streams/piping/abort.any.js.ini b/tests/wpt/meta/streams/piping/abort.any.js.ini index fc936d9420b..3d3e8a59942 100644 --- a/tests/wpt/meta/streams/piping/abort.any.js.ini +++ b/tests/wpt/meta/streams/piping/abort.any.js.ini @@ -5,6 +5,7 @@ expected: ERROR [abort.any.html] + expected: ERROR [a signal argument 'null' should cause pipeTo() to reject] expected: FAIL @@ -118,6 +119,7 @@ expected: ERROR [abort.any.worker.html] + expected: ERROR [a signal argument 'null' should cause pipeTo() to reject] expected: FAIL diff --git a/tests/wpt/meta/streams/piping/pipe-through.any.js.ini b/tests/wpt/meta/streams/piping/pipe-through.any.js.ini index 83561f9eea2..77cd1734611 100644 --- a/tests/wpt/meta/streams/piping/pipe-through.any.js.ini +++ b/tests/wpt/meta/streams/piping/pipe-through.any.js.ini @@ -5,28 +5,26 @@ expected: ERROR [pipe-through.any.worker.html] + expected: ERROR [pipeThrough should accept a real AbortSignal] expected: FAIL - [pipeThrough should not care if readable is locked] + [invalid values of signal should throw; specifically 'null'] expected: FAIL - [preventCancel should work] + [invalid values of signal should throw; specifically '0'] expected: FAIL - [preventClose should work] + [invalid values of signal should throw; specifically 'NaN'] expected: FAIL - [preventAbort should work] + [invalid values of signal should throw; specifically 'true'] expected: FAIL - [pipeThrough() should not throw if option is null] + [invalid values of signal should throw; specifically 'AbortSignal'] expected: FAIL - [pipeThrough() should not throw if signal is undefined] - expected: FAIL - - [pipeThrough() should throw if readable/writable getters throw] + [invalid values of signal should throw; specifically '[object AbortSignal\]'] expected: FAIL @@ -49,6 +47,7 @@ expected: ERROR [pipe-through.any.html] + expected: ERROR [pipeThrough should accept a real AbortSignal] expected: FAIL diff --git a/tests/wpt/mozilla/meta/MANIFEST.json b/tests/wpt/mozilla/meta/MANIFEST.json index e05f59524c5..bf19c365d17 100644 --- a/tests/wpt/mozilla/meta/MANIFEST.json +++ b/tests/wpt/mozilla/meta/MANIFEST.json @@ -13582,14 +13582,14 @@ ] ], "interfaces.https.html": [ - "0689f4c2305d808471fa3f530595d407e92fda30", + "eee8c799727b91e00b512795756b693a5f121f86", [ null, {} ] ], "interfaces.worker.js": [ - "9e4c15823f1b19c70d9a64bde0074dfe4ba63f29", + "e86f34f261442aeaa7074c525fb4b1206219769d", [ "mozilla/interfaces.worker.html", {} diff --git a/tests/wpt/mozilla/tests/mozilla/interfaces.https.html b/tests/wpt/mozilla/tests/mozilla/interfaces.https.html index 0689f4c2305..eee8c799727 100644 --- a/tests/wpt/mozilla/tests/mozilla/interfaces.https.html +++ b/tests/wpt/mozilla/tests/mozilla/interfaces.https.html @@ -11,8 +11,6 @@ // IMPORTANT: Do not change the list below without review from a DOM peer! test_interfaces([ - "AbortController", - "AbortSignal", "AbstractRange", "AnalyserNode", "AnimationEvent", diff --git a/tests/wpt/mozilla/tests/mozilla/interfaces.worker.js b/tests/wpt/mozilla/tests/mozilla/interfaces.worker.js index 9e4c15823f1..e86f34f2614 100644 --- a/tests/wpt/mozilla/tests/mozilla/interfaces.worker.js +++ b/tests/wpt/mozilla/tests/mozilla/interfaces.worker.js @@ -7,8 +7,6 @@ importScripts("interfaces.js"); // IMPORTANT: Do not change the list below without review from a DOM peer! test_interfaces([ - "AbortController", - "AbortSignal", "Blob", "BroadcastChannel", "ByteLengthQueuingStrategy",