Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-06-24 17:14:33 +01:00
Code Issues Projects Releases Packages Wiki Activity

Auto merge of #17757 - bholley:downgrade_assertion, r=bholley

Browse source 
Stop aborting release builds if we've missed invalidations before calling Servo_ResolveStyle

A lot of people are hitting this in [1]. I think having style (just potentially out-of-date) is less likely to cause weird crashes than failing to style the element entirely, so it's not worth inflicting this level of crashiness on the dogfood population.

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1381475
This commit is contained in:
bors-servo 2017-07-17 11:52:32 -07:00 • committed by GitHub
commit 602ef8bce1
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

2
ports/geckolib/glue.rs
View file

@ -2781,7 +2781,7 @@ pub extern "C" fn Servo_ResolveStyle(element: RawGeckoElementBorrowed,
// TODO(emilio): Downgrade to debug assertions when close to release.
assert!(data.has_styles(), "Resolving style on unstyled element");
assert!(element.has_current_styles(&*data),
debug_assert!(element.has_current_styles(&*data),
"Resolving style on element without current styles");
data.styles.primary().clone().into_strong()
}