Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-10 07:55:33 +01:00
Code Issues Projects Releases Packages Wiki Activity

Replace script_plugins with a clippy like rustc driver (named crown) (#30508)

Browse source 
* Remove script_plugins

* Use crown instead of script_plugins

* crown_is_not_used

* Use crown in command base

* bootstrap crown

* tidy happy

* disable sccache

* Bring crown in tree

* Install crown from tree

* fix windows ci

* fix warning

* fix mac

libscript_plugins.dylib is not available anymore

* Update components/script/lib.rs

Co-authored-by: Martin Robinson <mrobinson@igalia.com>

* Update for nightly-2023-03-18

Mostly just based off https://github.com/servo/servo/pull/30630

* Always install crown

it's slow only when there is new version

* Run crown test with `mach test-unit`

* Small fixups; better trace_in_no_trace tests

* Better doc

* crown in config.toml

* Fix tidy for real

* no sccache on rustc_wrapper

* document rustc overrides

* fixup of compiletest

* Make a few minor comment adjustments

* Fix a typo in python/servo/platform/base.py

Co-authored-by: Samson <16504129+sagudev@users.noreply.github.com>

* Proper test types

* Ignore tidy on crown/tests

---------

Co-authored-by: Martin Robinson <mrobinson@igalia.com>
This commit is contained in:
Samson 2023-12-01 16:50:52 +01:00 • committed by GitHub
parent 20a73721de
commit 604979e367
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
231 changed files with 881 additions and 680 deletions
Download patch file Download diff file Expand all files Collapse all files

13
tests/unit/script_plugins/Cargo.toml
View file

@ -1,13 +0,0 @@
[package]
name = "script_plugins_tests"
version = "0.0.1"
authors = ["The Servo Project Developers"]
license = "MPL-2.0"
edition = "2018"
[lib]
path = "lib.rs"
test = false
[dependencies]
script_plugins = {path = "../../../components/script_plugins", features = ["unrooted_must_root_lint", "trace_in_no_trace_lint"]}

164
tests/unit/script_plugins/lib.rs
View file

@ -1,164 +0,0 @@
/* This Source Code Form is subject to the terms of the Mozilla Public
* License, v. 2.0. If a copy of the MPL was not distributed with this
* file, You can obtain one at https://mozilla.org/MPL/2.0/. */
#[rustfmt::skip]
pub mod unrooted_must_root {
/**
```
#![feature(plugin, register_tool)]
#![plugin(script_plugins)]
#![register_tool(unrooted_must_root_lint)]
#[unrooted_must_root_lint::must_root] struct Foo(i32);
#[unrooted_must_root_lint::must_root] struct Bar(Foo);
fn foo1(_: &Foo) {}
fn foo2(_: &()) -> &Foo { unimplemented!() }
fn main() {}
```
*/
pub fn ok() {}
/**
```compile_fail
#![feature(plugin, register_tool)]
#![plugin(script_plugins)]
#![register_tool(unrooted_must_root_lint)]
#[unrooted_must_root_lint::must_root] struct Foo(i32);
struct Bar(Foo);
fn main() {}
```
*/
pub fn struct_field() {}
/**
```compile_fail
#![feature(plugin, register_tool)]
#![plugin(script_plugins)]
#![register_tool(unrooted_must_root_lint)]
#[unrooted_must_root_lint::must_root] struct Foo(i32);
fn foo1(_: Foo) {}
fn main() {}
```
*/
pub fn parameter() {}
/**
```compile_fail
#![feature(plugin, register_tool)]
#![plugin(script_plugins)]
#![register_tool(unrooted_must_root_lint)]
#[unrooted_must_root_lint::must_root] struct Foo(i32);
fn foo2() -> Foo { unimplemented!() }
fn main() {}
```
*/
pub fn return_type() {}
}
#[rustfmt::skip]
pub mod trace_in_no_trace_lint {
/// Fake jstraceable
pub trait JSTraceable {}
impl JSTraceable for i32 {}
/**
```
#![allow(deprecated)]
#![feature(plugin, register_tool)]
#![plugin(script_plugins)]
#![register_tool(trace_in_no_trace_lint)]
use script_plugins_tests::trace_in_no_trace_lint::JSTraceable;
#[trace_in_no_trace_lint::must_not_have_traceable] struct NoTrace<T>(T);
struct Bar;
struct Foo(NoTrace<Bar>);
fn main() {}
```
*/
pub fn ok() {}
/**
```compile_fail
#![allow(deprecated)]
#![feature(plugin, register_tool)]
#![plugin(script_plugins)]
#![register_tool(trace_in_no_trace_lint)]
use script_plugins_tests::trace_in_no_trace_lint::JSTraceable;
#[trace_in_no_trace_lint::must_not_have_traceable] struct NoTrace<T>(T);
struct Bar;
impl JSTraceable for Bar {}
struct Foo(NoTrace<Bar>);
fn main() {}
```
*/
pub fn works() {}
/**
```
#![allow(deprecated)]
#![feature(plugin, register_tool)]
#![plugin(script_plugins)]
#![register_tool(trace_in_no_trace_lint)]
use script_plugins_tests::trace_in_no_trace_lint::JSTraceable;
// second generic argument must not be traceable
#[trace_in_no_trace_lint::must_not_have_traceable(1)]
struct NoTraceComposable<Traceable, NoTraceable> {
t: Traceable,
n: NoTraceable,
}
// this is ok u32 is not traceable
struct Foo(NoTraceComposable<i32, u32>);
fn main() {}
```
*/
pub fn composable_ok() {}
/**
```
#![allow(deprecated)]
#![feature(plugin, register_tool)]
#![plugin(script_plugins)]
#![register_tool(trace_in_no_trace_lint)]
use script_plugins_tests::trace_in_no_trace_lint::JSTraceable;
// second generic argument must not be traceable
#[trace_in_no_trace_lint::must_not_have_traceable(1)]
struct NoTraceComposable<Traceable, NoTraceable> {
t: Traceable,
n: NoTraceable,
}
// this is not ok i32 is traceable
struct Foo(NoTraceComposable<u32, i32>);
fn main() {}
```
*/
pub fn composable_works() {}
}