Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-04 13:10:20 +01:00
Code Issues Projects Releases Packages Wiki Activity

deny_public_fields: display field identifier in help message

Browse source 
Use a binding's field identifier to produce more descriptive output.
Fall back to a binding's identifier if a field identifier is not
available.

Additionally, make the privatize.rs compiletest more specific and
wrap the identifier in backticks to aid readability.
This commit is contained in:
Harvey Hunt 2017-06-24 00:21:52 +01:00
parent 946c9aede1
commit 6081241962
2 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
components/deny_public_fields/lib.rs
View file

@ -17,7 +17,8 @@ fn expand_string(input: &str) -> String {
let style = synstructure::BindStyle::Ref.into(); let style = synstructure::BindStyle::Ref.into();
synstructure::each_field(&type_, &style, |binding| { synstructure::each_field(&type_, &style, |binding| {
if binding.field.vis != syn::Visibility::Inherited { if binding.field.vis != syn::Visibility::Inherited {
panic!("Field {} should not be public", binding.ident); panic!("Field `{}` should not be public",
binding.field.ident.as_ref().unwrap_or(&binding.ident));
} }
"".to_owned() "".to_owned()
}); });

1
tests/compiletest/plugin/compile-fail/privatize.rs
View file

@ -9,6 +9,7 @@ extern crate deny_public_fields;
#[derive(DenyPublicFields)] #[derive(DenyPublicFields)]
//~^ ERROR proc-macro derive panicked //~^ ERROR proc-macro derive panicked
//~| HELP Field `v1` should not be public
struct Foo { struct Foo {
pub v1: i32, pub v1: i32,
v2: i32 v2: i32