Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-06 14:10:11 +01:00
Code Issues Projects Releases Packages Wiki Activity

Start marking functions that can transitively trigger a GC (#33144)

Browse source 
* Mark JS reflector wrappers as CanGc.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Propagate CanGc from reflect_dom_object_with_proto.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Mark DOM constructors as GC operations.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

---------

Signed-off-by: Josh Matthews <josh@joshmatthews.net>
This commit is contained in:
Josh Matthews 2024-08-22 07:42:36 -04:00 • committed by GitHub
parent 9a1051c917
commit 60ef6bc461
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
140 changed files with 1336 additions and 304 deletions
Download patch file Download diff file Expand all files Collapse all files

15
components/script/dom/compositionevent.rs
View file

@ -15,6 +15,7 @@ use crate::dom::bindings::root::DomRoot;
use crate::dom::bindings::str::DOMString;
use crate::dom::uievent::UIEvent;
use crate::dom::window::Window;
use crate::script_runtime::CanGc;
#[dom_struct]
pub struct CompositionEvent {
@ -44,7 +45,15 @@ impl CompositionEvent {
data: DOMString,
) -> DomRoot<CompositionEvent> {
Self::new_with_proto(
window, None, type_, can_bubble, cancelable, view, detail, data,
window,
None,
type_,
can_bubble,
cancelable,
view,
detail,
data,
CanGc::note(),
)
}
@ -58,6 +67,7 @@ impl CompositionEvent {
view: Option<&Window>,
detail: i32,
data: DOMString,
can_gc: CanGc,
) -> DomRoot<CompositionEvent> {
let ev = reflect_dom_object_with_proto(
Box::new(CompositionEvent {
@ -66,6 +76,7 @@ impl CompositionEvent {
}),
window,
proto,
can_gc,
);
ev.uievent
.InitUIEvent(type_, can_bubble, cancelable, view, detail);
@ -76,6 +87,7 @@ impl CompositionEvent {
pub fn Constructor(
window: &Window,
proto: Option<HandleObject>,
can_gc: CanGc,
type_: DOMString,
init: &CompositionEventBinding::CompositionEventInit,
) -> Fallible<DomRoot<CompositionEvent>> {
@ -88,6 +100,7 @@ impl CompositionEvent {
init.parent.view.as_deref(),
init.parent.detail,
init.data.clone(),
can_gc,
);
Ok(event)
}