Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-08 06:55:31 +01:00
Code Issues Projects Releases Packages Wiki Activity

Start marking functions that can transitively trigger a GC (#33144)

Browse source 
* Mark JS reflector wrappers as CanGc.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Propagate CanGc from reflect_dom_object_with_proto.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Mark DOM constructors as GC operations.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

---------

Signed-off-by: Josh Matthews <josh@joshmatthews.net>
This commit is contained in:
Josh Matthews 2024-08-22 07:42:36 -04:00 • committed by GitHub
parent 9a1051c917
commit 60ef6bc461
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
140 changed files with 1336 additions and 304 deletions
Download patch file Download diff file Expand all files Collapse all files

17
components/script/dom/customevent.rs
View file

@ -19,7 +19,7 @@ use crate::dom::bindings::str::DOMString;
use crate::dom::bindings::trace::RootedTraceableBox;
use crate::dom::event::Event;
use crate::dom::globalscope::GlobalScope;
use crate::script_runtime::JSContext;
use crate::script_runtime::{CanGc, JSContext};
// https://dom.spec.whatwg.org/#interface-customevent
#[dom_struct]
@ -38,14 +38,20 @@ impl CustomEvent {
}
pub fn new_uninitialized(global: &GlobalScope) -> DomRoot<CustomEvent> {
Self::new_uninitialized_with_proto(global, None)
Self::new_uninitialized_with_proto(global, None, CanGc::note())
}
fn new_uninitialized_with_proto(
global: &GlobalScope,
proto: Option<HandleObject>,
can_gc: CanGc,
) -> DomRoot<CustomEvent> {
reflect_dom_object_with_proto(Box::new(CustomEvent::new_inherited()), global, proto)
reflect_dom_object_with_proto(
Box::new(CustomEvent::new_inherited()),
global,
proto,
can_gc,
)
}
fn new(
@ -55,8 +61,9 @@ impl CustomEvent {
bubbles: bool,
cancelable: bool,
detail: HandleValue,
can_gc: CanGc,
) -> DomRoot<CustomEvent> {
let ev = CustomEvent::new_uninitialized_with_proto(global, proto);
let ev = CustomEvent::new_uninitialized_with_proto(global, proto, can_gc);
ev.init_custom_event(type_, bubbles, cancelable, detail);
ev
}
@ -65,6 +72,7 @@ impl CustomEvent {
pub fn Constructor(
global: &GlobalScope,
proto: Option<HandleObject>,
can_gc: CanGc,
type_: DOMString,
init: RootedTraceableBox<CustomEventBinding::CustomEventInit>,
) -> Fallible<DomRoot<CustomEvent>> {
@ -75,6 +83,7 @@ impl CustomEvent {
init.parent.bubbles,
init.parent.cancelable,
init.detail.handle(),
can_gc,
))
}