mirror of
https://github.com/servo/servo.git
synced 2025-08-03 04:30:10 +01:00
Start marking functions that can transitively trigger a GC (#33144)
* Mark JS reflector wrappers as CanGc. Signed-off-by: Josh Matthews <josh@joshmatthews.net> * Propagate CanGc from reflect_dom_object_with_proto. Signed-off-by: Josh Matthews <josh@joshmatthews.net> * Mark DOM constructors as GC operations. Signed-off-by: Josh Matthews <josh@joshmatthews.net> --------- Signed-off-by: Josh Matthews <josh@joshmatthews.net>
This commit is contained in:
parent
9a1051c917
commit
60ef6bc461
140 changed files with 1336 additions and 304 deletions
|
@ -12,6 +12,7 @@ use crate::dom::bindings::reflector::reflect_dom_object_with_proto;
|
|||
use crate::dom::bindings::root::DomRoot;
|
||||
use crate::dom::dompointreadonly::{DOMPointReadOnly, DOMPointWriteMethods};
|
||||
use crate::dom::globalscope::GlobalScope;
|
||||
use crate::script_runtime::CanGc;
|
||||
|
||||
// http://dev.w3.org/fxtf/geometry/Overview.html#dompoint
|
||||
#[dom_struct]
|
||||
|
@ -28,7 +29,7 @@ impl DOMPoint {
|
|||
}
|
||||
|
||||
pub fn new(global: &GlobalScope, x: f64, y: f64, z: f64, w: f64) -> DomRoot<DOMPoint> {
|
||||
Self::new_with_proto(global, None, x, y, z, w)
|
||||
Self::new_with_proto(global, None, x, y, z, w, CanGc::note())
|
||||
}
|
||||
|
||||
fn new_with_proto(
|
||||
|
@ -38,19 +39,26 @@ impl DOMPoint {
|
|||
y: f64,
|
||||
z: f64,
|
||||
w: f64,
|
||||
can_gc: CanGc,
|
||||
) -> DomRoot<DOMPoint> {
|
||||
reflect_dom_object_with_proto(Box::new(DOMPoint::new_inherited(x, y, z, w)), global, proto)
|
||||
reflect_dom_object_with_proto(
|
||||
Box::new(DOMPoint::new_inherited(x, y, z, w)),
|
||||
global,
|
||||
proto,
|
||||
can_gc,
|
||||
)
|
||||
}
|
||||
|
||||
pub fn Constructor(
|
||||
global: &GlobalScope,
|
||||
proto: Option<HandleObject>,
|
||||
can_gc: CanGc,
|
||||
x: f64,
|
||||
y: f64,
|
||||
z: f64,
|
||||
w: f64,
|
||||
) -> Fallible<DomRoot<DOMPoint>> {
|
||||
Ok(DOMPoint::new_with_proto(global, proto, x, y, z, w))
|
||||
Ok(DOMPoint::new_with_proto(global, proto, x, y, z, w, can_gc))
|
||||
}
|
||||
|
||||
// https://drafts.fxtf.org/geometry/#dom-dompoint-frompoint
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue