Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-07 06:25:32 +01:00
Code Issues Projects Releases Packages Wiki Activity

Start marking functions that can transitively trigger a GC (#33144)

Browse source 
* Mark JS reflector wrappers as CanGc.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Propagate CanGc from reflect_dom_object_with_proto.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Mark DOM constructors as GC operations.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

---------

Signed-off-by: Josh Matthews <josh@joshmatthews.net>
This commit is contained in:
Josh Matthews 2024-08-22 07:42:36 -04:00 • committed by GitHub
parent 9a1051c917
commit 60ef6bc461
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
140 changed files with 1336 additions and 304 deletions
Download patch file Download diff file Expand all files Collapse all files

7
components/script/dom/domquad.rs
View file

@ -14,6 +14,7 @@ use crate::dom::bindings::root::{Dom, DomRoot};
use crate::dom::dompoint::DOMPoint;
use crate::dom::domrect::DOMRect;
use crate::dom::globalscope::GlobalScope;
use crate::script_runtime::CanGc;
// https://drafts.fxtf.org/geometry/#DOMQuad
#[dom_struct]
@ -44,7 +45,7 @@ impl DOMQuad {
p3: &DOMPoint,
p4: &DOMPoint,
) -> DomRoot<DOMQuad> {
Self::new_with_proto(global, None, p1, p2, p3, p4)
Self::new_with_proto(global, None, p1, p2, p3, p4, CanGc::note())
}
fn new_with_proto(
@ -54,17 +55,20 @@ impl DOMQuad {
p2: &DOMPoint,
p3: &DOMPoint,
p4: &DOMPoint,
can_gc: CanGc,
) -> DomRoot<DOMQuad> {
reflect_dom_object_with_proto(
Box::new(DOMQuad::new_inherited(p1, p2, p3, p4)),
global,
proto,
can_gc,
)
}
pub fn Constructor(
global: &GlobalScope,
proto: Option<HandleObject>,
can_gc: CanGc,
p1: &DOMPointInit,
p2: &DOMPointInit,
p3: &DOMPointInit,
@ -77,6 +81,7 @@ impl DOMQuad {
&DOMPoint::new_from_init(global, p2),
&DOMPoint::new_from_init(global, p3),
&DOMPoint::new_from_init(global, p4),
can_gc,
))
}