Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-06 14:10:11 +01:00
Code Issues Projects Releases Packages Wiki Activity

Start marking functions that can transitively trigger a GC (#33144)

Browse source 
* Mark JS reflector wrappers as CanGc.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Propagate CanGc from reflect_dom_object_with_proto.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Mark DOM constructors as GC operations.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

---------

Signed-off-by: Josh Matthews <josh@joshmatthews.net>
This commit is contained in:
Josh Matthews 2024-08-22 07:42:36 -04:00 • committed by GitHub
parent 9a1051c917
commit 60ef6bc461
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
140 changed files with 1336 additions and 304 deletions
Download patch file Download diff file Expand all files Collapse all files

10
components/script/dom/domrect.rs
View file

@ -12,6 +12,7 @@ use crate::dom::bindings::reflector::reflect_dom_object_with_proto;
use crate::dom::bindings::root::DomRoot;
use crate::dom::domrectreadonly::DOMRectReadOnly;
use crate::dom::globalscope::GlobalScope;
use crate::script_runtime::CanGc;
#[dom_struct]
pub struct DOMRect {
@ -26,7 +27,7 @@ impl DOMRect {
}
pub fn new(global: &GlobalScope, x: f64, y: f64, width: f64, height: f64) -> DomRoot<DOMRect> {
Self::new_with_proto(global, None, x, y, width, height)
Self::new_with_proto(global, None, x, y, width, height, CanGc::note())
}
fn new_with_proto(
@ -36,11 +37,13 @@ impl DOMRect {
y: f64,
width: f64,
height: f64,
can_gc: CanGc,
) -> DomRoot<DOMRect> {
reflect_dom_object_with_proto(
Box::new(DOMRect::new_inherited(x, y, width, height)),
global,
proto,
can_gc,
)
}
@ -48,12 +51,15 @@ impl DOMRect {
pub fn Constructor(
global: &GlobalScope,
proto: Option<HandleObject>,
can_gc: CanGc,
x: f64,
y: f64,
width: f64,
height: f64,
) -> Fallible<DomRoot<DOMRect>> {
Ok(DOMRect::new_with_proto(global, proto, x, y, width, height))
Ok(DOMRect::new_with_proto(
global, proto, x, y, width, height, can_gc,
))
}
}