Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-06 14:10:11 +01:00
Code Issues Projects Releases Packages Wiki Activity

Start marking functions that can transitively trigger a GC (#33144)

Browse source 
* Mark JS reflector wrappers as CanGc.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Propagate CanGc from reflect_dom_object_with_proto.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Mark DOM constructors as GC operations.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

---------

Signed-off-by: Josh Matthews <josh@joshmatthews.net>
This commit is contained in:
Josh Matthews 2024-08-22 07:42:36 -04:00 • committed by GitHub
parent 9a1051c917
commit 60ef6bc461
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
140 changed files with 1336 additions and 304 deletions
Download patch file Download diff file Expand all files Collapse all files

7
components/script/dom/file.rs
View file

@ -18,6 +18,7 @@ use crate::dom::bindings::str::DOMString;
use crate::dom::blob::{blob_parts_to_bytes, normalize_type_string, Blob};
use crate::dom::globalscope::GlobalScope;
use crate::dom::window::Window;
use crate::script_runtime::CanGc;
#[dom_struct]
pub struct File {
@ -49,7 +50,7 @@ impl File {
name: DOMString,
modified: Option<i64>,
) -> DomRoot<File> {
Self::new_with_proto(global, None, blob_impl, name, modified)
Self::new_with_proto(global, None, blob_impl, name, modified, CanGc::note())
}
#[allow(crown::unrooted_must_root)]
@ -59,11 +60,13 @@ impl File {
blob_impl: BlobImpl,
name: DOMString,
modified: Option<i64>,
can_gc: CanGc,
) -> DomRoot<File> {
let file = reflect_dom_object_with_proto(
Box::new(File::new_inherited(&blob_impl, name, modified)),
global,
proto,
can_gc,
);
global.track_file(&file, blob_impl);
file
@ -96,6 +99,7 @@ impl File {
pub fn Constructor(
global: &GlobalScope,
proto: Option<HandleObject>,
can_gc: CanGc,
fileBits: Vec<ArrayBufferOrArrayBufferViewOrBlobOrString>,
filename: DOMString,
filePropertyBag: &FileBinding::FilePropertyBag,
@ -118,6 +122,7 @@ impl File {
BlobImpl::new_from_bytes(bytes, type_string),
replaced_filename,
modified,
can_gc,
))
}