Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-06 22:15:33 +01:00
Code Issues Projects Releases Packages Wiki Activity

Start marking functions that can transitively trigger a GC (#33144)

Browse source 
* Mark JS reflector wrappers as CanGc.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Propagate CanGc from reflect_dom_object_with_proto.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Mark DOM constructors as GC operations.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

---------

Signed-off-by: Josh Matthews <josh@joshmatthews.net>
This commit is contained in:
Josh Matthews 2024-08-22 07:42:36 -04:00 • committed by GitHub
parent 9a1051c917
commit 60ef6bc461
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
140 changed files with 1336 additions and 304 deletions
Download patch file Download diff file Expand all files Collapse all files

12
components/script/dom/focusevent.rs
View file

@ -19,6 +19,7 @@ use crate::dom::event::{EventBubbles, EventCancelable};
use crate::dom::eventtarget::EventTarget;
use crate::dom::uievent::UIEvent;
use crate::dom::window::Window;
use crate::script_runtime::CanGc;
#[dom_struct]
pub struct FocusEvent {
@ -35,14 +36,15 @@ impl FocusEvent {
}
pub fn new_uninitialized(window: &Window) -> DomRoot<FocusEvent> {
Self::new_uninitialized_with_proto(window, None)
Self::new_uninitialized_with_proto(window, None, CanGc::note())
}
pub fn new_uninitialized_with_proto(
window: &Window,
proto: Option<HandleObject>,
can_gc: CanGc,
) -> DomRoot<FocusEvent> {
reflect_dom_object_with_proto(Box::new(FocusEvent::new_inherited()), window, proto)
reflect_dom_object_with_proto(Box::new(FocusEvent::new_inherited()), window, proto, can_gc)
}
pub fn new(
@ -63,6 +65,7 @@ impl FocusEvent {
view,
detail,
related_target,
CanGc::note(),
)
}
@ -76,8 +79,9 @@ impl FocusEvent {
view: Option<&Window>,
detail: i32,
related_target: Option<&EventTarget>,
can_gc: CanGc,
) -> DomRoot<FocusEvent> {
let ev = FocusEvent::new_uninitialized_with_proto(window, proto);
let ev = FocusEvent::new_uninitialized_with_proto(window, proto, can_gc);
ev.upcast::<UIEvent>().InitUIEvent(
type_,
bool::from(can_bubble),
@ -93,6 +97,7 @@ impl FocusEvent {
pub fn Constructor(
window: &Window,
proto: Option<HandleObject>,
can_gc: CanGc,
type_: DOMString,
init: &FocusEventBinding::FocusEventInit,
) -> Fallible<DomRoot<FocusEvent>> {
@ -107,6 +112,7 @@ impl FocusEvent {
init.parent.view.as_deref(),
init.parent.detail,
init.relatedTarget.as_deref(),
can_gc,
);
Ok(event)
}