Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-06-06 16:45:39 +00:00
Code Issues Projects Releases Packages Wiki Activity

Start marking functions that can transitively trigger a GC (#33144)

Browse source 
* Mark JS reflector wrappers as CanGc.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Propagate CanGc from reflect_dom_object_with_proto.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Mark DOM constructors as GC operations.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

---------

Signed-off-by: Josh Matthews <josh@joshmatthews.net>
This commit is contained in:
Josh Matthews 2024-08-22 07:42:36 -04:00 • committed by GitHub
parent 9a1051c917
commit 60ef6bc461
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
140 changed files with 1336 additions and 304 deletions
Download patch file Download diff file Expand all files Collapse all files

15
components/script/dom/formdataevent.rs
View file

@ -18,6 +18,7 @@ use crate::dom::event::{Event, EventBubbles, EventCancelable};
use crate::dom::formdata::FormData;
use crate::dom::globalscope::GlobalScope;
use crate::dom::window::Window;
use crate::script_runtime::CanGc;
#[dom_struct]
pub struct FormDataEvent {
@ -33,7 +34,15 @@ impl FormDataEvent {
cancelable: EventCancelable,
form_data: &FormData,
) -> DomRoot<FormDataEvent> {
Self::new_with_proto(global, None, type_, can_bubble, cancelable, form_data)
Self::new_with_proto(
global,
None,
type_,
can_bubble,
cancelable,
form_data,
CanGc::note(),
)
}
fn new_with_proto(
@ -43,6 +52,7 @@ impl FormDataEvent {
can_bubble: EventBubbles,
cancelable: EventCancelable,
form_data: &FormData,
can_gc: CanGc,
) -> DomRoot<FormDataEvent> {
let ev = reflect_dom_object_with_proto(
Box::new(FormDataEvent {
@ -51,6 +61,7 @@ impl FormDataEvent {
}),
global,
proto,
can_gc,
);
{
@ -64,6 +75,7 @@ impl FormDataEvent {
pub fn Constructor(
window: &Window,
proto: Option<HandleObject>,
can_gc: CanGc,
type_: DOMString,
init: &FormDataEventBinding::FormDataEventInit,
) -> Fallible<DomRoot<FormDataEvent>> {
@ -77,6 +89,7 @@ impl FormDataEvent {
bubbles,
cancelable,
&init.formData.clone(),
can_gc,
);
Ok(event)