Start marking functions that can transitively trigger a GC (#33144)

* Mark JS reflector wrappers as CanGc.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Propagate CanGc from reflect_dom_object_with_proto.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

* Mark DOM constructors as GC operations.

Signed-off-by: Josh Matthews <josh@joshmatthews.net>

---------

Signed-off-by: Josh Matthews <josh@joshmatthews.net>
This commit is contained in:
Josh Matthews 2024-08-22 07:42:36 -04:00 committed by GitHub
parent 9a1051c917
commit 60ef6bc461
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
140 changed files with 1336 additions and 304 deletions

View file

@ -16,6 +16,7 @@ use crate::dom::bindings::str::DOMString;
use crate::dom::event::Event;
use crate::dom::globalscope::GlobalScope;
use crate::dom::gpuerror::GPUError;
use crate::script_runtime::CanGc;
#[dom_struct]
pub struct GPUUncapturedErrorEvent {
@ -37,7 +38,7 @@ impl GPUUncapturedErrorEvent {
type_: DOMString,
init: &GPUUncapturedErrorEventInit,
) -> DomRoot<Self> {
Self::new_with_proto(global, None, type_, init)
Self::new_with_proto(global, None, type_, init, CanGc::note())
}
fn new_with_proto(
@ -45,11 +46,13 @@ impl GPUUncapturedErrorEvent {
proto: Option<HandleObject>,
type_: DOMString,
init: &GPUUncapturedErrorEventInit,
can_gc: CanGc,
) -> DomRoot<Self> {
let ev = reflect_dom_object_with_proto(
Box::new(GPUUncapturedErrorEvent::new_inherited(init)),
global,
proto,
can_gc,
);
ev.event.init_event(
Atom::from(type_),
@ -64,10 +67,11 @@ impl GPUUncapturedErrorEvent {
pub fn Constructor(
global: &GlobalScope,
proto: Option<HandleObject>,
can_gc: CanGc,
type_: DOMString,
init: &GPUUncapturedErrorEventInit,
) -> DomRoot<Self> {
GPUUncapturedErrorEvent::new_with_proto(global, proto, type_, init)
GPUUncapturedErrorEvent::new_with_proto(global, proto, type_, init, can_gc)
}
}